[TFMonhHx] Forces new version of netty #450
Conversation
ncordon
force-pushed
the
dev-bumps-netty-version
branch
3 times, most recently
from
0c01aeb to
7c67284
Compare
ncordon
force-pushed
the
dev-bumps-netty-version
branch
from
7c67284 to
a592576
Compare
| } | ||
|
|
||
| implementation group: 'org.apache.arrow', name: 'arrow-vector', version: '12.0.1', arrowExclusions | ||
| implementation group: 'org.apache.arrow', name: 'arrow-memory-netty', version: '12.0.1', arrowExclusions |
There was a problem hiding this comment.
Don't forget to update LICENSES :)
There was a problem hiding this comment.
This puzzled me cause I thought the CI was checking for those because of the work you did. I think you were right we need to add an extra step: #451
There was a problem hiding this comment.
Hmm this is weird, because I tested it out by pushing with missing parts and it had worked then 🤔
ncordon
force-pushed
the
dev-bumps-netty-version
branch
from
b2cda0a to
1383134
Compare
| netty-common-4.1.93.Final.jar | ||
| netty-common-4.1.94.Final.jar |
There was a problem hiding this comment.
Any hint on why do we get two versions in the LICENSES @gem-neo4j even if we are overwritting with the most recent one?
There was a problem hiding this comment.
The LICENSE file is a mix of core and common, so I believe common doesn't have 4.1.94 yet in its dependency tree
There was a problem hiding this comment.
Might be from test-utils actually, I see arrow is on 10.0.1 there, should that be updated?
There was a problem hiding this comment.
It's not that, I've tried overriding there as well. This should heal automatically anyway when the database updates to 4.1.94
ncordon
force-pushed
the
dev-bumps-netty-version
branch
from
252d907 to
4139cd7
Compare
2 participants
What
This PR needs to be merged in conjunction with the latest version of the database
It makes possible to use the latest version of netty.
The issue is reproduced in a592576 and we can see how 2f0a268 solves it.
Why
A class was renamed changed between the
4.1.93.Finalversion of netty and4.1.94.Final, which neo4j is intending to use. We depend on arrow, which was only updated (but not released) 2 weeks ago, so the netty dependency there needs to be an old one.The only way to do this is to copy the file available in arrow and override it with the name change
PoolThreadCachetoPoolArenasCachetemporarily until arrow has been released.