Skip to content

Conversation

@lriggs
Copy link

@lriggs lriggs commented Jun 28, 2023

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845 This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

This PR contains a "Critical Fix".

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

Authored-by: Bryan Cutler [email protected]

…pache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <[email protected]>
Signed-off-by: David Li <[email protected]>
@github-actions
Copy link

❌ GitHub issue apache#36209 could not be retrieved.

@xxlaykxx xxlaykxx self-requested a review June 28, 2023 17:27
@lriggs lriggs merged commit ab2495b into dremio:dremio-12.0-main Jun 28, 2023
lriggs added a commit that referenced this pull request Jul 13, 2023
…pache#36211) (#27)

* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <[email protected]>
Signed-off-by: David Li <[email protected]>

* Restore jackson version.

---------

Signed-off-by: David Li <[email protected]>
Co-authored-by: Bryan Cutler <[email protected]>
lriggs added a commit that referenced this pull request Jul 21, 2023
…pache#36211) (#27)

* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <[email protected]>
Signed-off-by: David Li <[email protected]>

* Restore jackson version.

---------

Signed-off-by: David Li <[email protected]>
Co-authored-by: Bryan Cutler <[email protected]>
lriggs added a commit that referenced this pull request Jul 28, 2023
…pache#36211) (#27)

* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <[email protected]>
Signed-off-by: David Li <[email protected]>

* Restore jackson version.

---------

Signed-off-by: David Li <[email protected]>
Co-authored-by: Bryan Cutler <[email protected]>
DenisTarasyuk pushed a commit that referenced this pull request Dec 19, 2023
…pache#36211) (#27)

* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <[email protected]>
Signed-off-by: David Li <[email protected]>

* Restore jackson version.

---------

Signed-off-by: David Li <[email protected]>
Co-authored-by: Bryan Cutler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants