Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing new compatible Dotnet versions to restore, build and publish #3189

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Allowing new compatible Dotnet versions to restore, build and publish #3189

merged 2 commits into from
Apr 4, 2024

Conversation

vncoelho
Copy link
Member

@vncoelho vncoelho commented Apr 1, 2024

close #3188

@vncoelho vncoelho changed the title Newer SDK versions should be allowed to build the project Allowing new compatible Dotnet versions to restore, build and publish Apr 2, 2024
AnnaShaleva
AnnaShaleva approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this change locally to build with fresh dotnet :D

@shargon shargon merged commit 020337c into master Apr 4, 2024
6 checks passed
@shargon shargon deleted the vncoelho-patch-1 branch April 4, 2024 07:58
shargon added a commit to neo-project/neo-devpack-dotnet that referenced this pull request Apr 4, 2024
@shargon
Allowing new compatible Dotnet versions to restore, build and publish
ac63d59 
Copy of neo-project/neo#3189
@shargon shargon mentioned this pull request Apr 4, 2024
Merged
vncoelho pushed a commit to neo-project/neo-devpack-dotnet that referenced this pull request Apr 4, 2024
@shargon
Allowing new compatible Dotnet versions to restore, build and publish (…
2b6c42d 
…#1012)

Copy of neo-project/neo#3189
@cschuchardt88
Copy link
Member

cschuchardt88 commented May 6, 2024 •
edited
Loading

This shouldn't of been changed. This has nothing to do with #3188. Your lucky they added support for 8.0.204 in Visual Studio. You didn't event update github workflows.

I don't know why I didn't see this 👀

I nominate myself to be project/repo maintenance person; since I'm always cleaning up.... 🦺

@vncoelho
Copy link
Member Author

vncoelho commented May 6, 2024

This shouldn't of been changed. This has nothing to do with #3188. Your lucky they added support for 8.0.204 in Visual Studio or else this wouldn't of worked. You didn't event update github workflows.

I don't know why I didn't see this 👀

I nominate myself to be project/repo maintenance person; since I'm always cleaning up.... 🦺

No Cris, this was causing problems.

Next time, please be more careful and keep compatibility for all devs.

Read the PR discussions. This was forcing devs to change this config locally.

@cschuchardt88
Copy link
Member

You know the reason it was like that before? Lets not forget #3183

cschuchardt88 added a commit to cschuchardt88/neo that referenced this pull request May 6, 2024
@cschuchardt88
Added missing github workflows changes from neo-project#3189
0f89e28
@cschuchardt88 cschuchardt88 mentioned this pull request May 6, 2024
Merged
8 tasks
shargon added a commit that referenced this pull request May 7, 2024
@cschuchardt88 @shargon
Added missing github workflows changes from #3189 (#3213)
2006938 
Co-authored-by: Shargon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@shargon shargon shargon approved these changes

@cschuchardt88 cschuchardt88 Awaiting requested review from cschuchardt88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow newer versions to compile or run the project
4 participants
@vncoelho @cschuchardt88 @shargon @AnnaShaleva