Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Configuration Fixes #3183

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Repo Configuration Fixes #3183

merged 10 commits into from
Mar 27, 2024

Conversation

cschuchardt88
Copy link
Member

Change Log

  • Fixed reporting with coverlet.msbuild
  • Updated dotnet version to 8.0.202 in global.json file
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y
Copy link
Contributor

Jim8y commented Mar 26, 2024

version must be specified?

.github/workflows/main.yml Outdated Show resolved Hide resolved
@cschuchardt88
Copy link
Member Author

Working Great Now
👍 🛩️ 💯 🥇 😃

@shargon @Jim8y @vncoelho

[coverlet] 
Calculating coverage result...
  [coverlet] MergeWith: '/home/runner/work/neo/neo/TestResults/coverage/coverage.net8.0.json'.
  Generating report '/home/runner/work/neo/neo/TestResults/coverage/coverage.net8.0.info'

+----------------------------+--------+--------+--------+
| Module                     | Line   | Branch | Method |
+----------------------------+--------+--------+--------+
| Neo.Json                   | 84.71% | 65.33% | 81.5%  |
+----------------------------+--------+--------+--------+
| Neo.VM                     | 87.65% | 80.6%  | 88.3%  |
+----------------------------+--------+--------+--------+
| Neo.Cryptography.BLS12_381 | 87.99% | 63%    | 73.96% |
+----------------------------+--------+--------+--------+
| Neo                        | 78.9%  | 65.38% | 81.61% |
+----------------------------+--------+--------+--------+
| Neo.Extensions             | 78.57% | 0%     | 80%    |
+----------------------------+--------+--------+--------+
| Neo.IO                     | 75.36% | 83.82% | 75%    |
+----------------------------+--------+--------+--------+
| Neo.ConsoleService         | 15.66% | 13.04% | 19.4%  |
+----------------------------+--------+--------+--------+
+---------+--------+--------+--------+
|         | Line   | Branch | Method |
+---------+--------+--------+--------+
| Total   | 79.22% | 65.6%  | 80.6%  |
+---------+--------+--------+--------+
| Average | 72.69% | 53.02% | 71.39% |
+---------+--------+--------+--------+

Jim8y
Jim8y previously approved these changes Mar 26, 2024
@Jim8y Jim8y requested a review from AnnaShaleva March 26, 2024 11:55
@cschuchardt88
Copy link
Member Author

@Jim8y Sorry I forgot one thing...

@cschuchardt88 cschuchardt88 requested a review from Jim8y March 26, 2024 11:59
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the coverage increase in 65822cf

That is why it decreases now

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the -m:1

The main fix here was the problem introduced in the last but one PR that forced all formats to be lcov

@cschuchardt88 cschuchardt88 requested a review from vncoelho March 26, 2024 15:25
@shargon
Copy link
Member

shargon commented Mar 27, 2024

Lcov havent got the namespace information I think

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be legit.

@shargon shargon merged commit c550fc2 into neo-project:master Mar 27, 2024
5 of 6 checks passed
@shargon shargon deleted the fix/repo branch March 27, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants