-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from solidusio:main #400
Commits on Mar 2, 2024
-
Add a promotion finder class for the classic promotion system
This is intended to be used by the API Promotions Controller.
Configuration menu - View commit details
-
Copy full SHA for 255935d - Browse repository at this point
Copy the full SHA 255935dView commit details -
This configurable class finds a promotion by its code.
Configuration menu - View commit details
-
Copy full SHA for 1e1c0f8 - Browse repository at this point
Copy the full SHA 1e1c0f8View commit details -
Make the promotion finder class configurable
The default has to be the Null promotion finder.
Configuration menu - View commit details
-
Copy full SHA for d5039de - Browse repository at this point
Copy the full SHA d5039deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b49501 - Browse repository at this point
Copy the full SHA 9b49501View commit details -
Use promotion finder in API promotions controller
The API promotions controller is pretty straightforward, and the only touch point here is finding a promotion. With that added to the promotion configuration, we can now use it with no changes to our specs.
Configuration menu - View commit details
-
Copy full SHA for eb76aae - Browse repository at this point
Copy the full SHA eb76aaeView commit details -
Promotions Request Spec: Stub Finder
This allows us to change the promotion system with factories, because we stop using factories in this spec.
Configuration menu - View commit details
-
Copy full SHA for 2f29de0 - Browse repository at this point
Copy the full SHA 2f29de0View commit details -
Scaffold for solidus_legacy_promotions extension
We want to extract the legacy promotion system from Solidus into its own gem to facilitate moving towards solidus_promotions.
Configuration menu - View commit details
-
Copy full SHA for 5b136ab - Browse repository at this point
Copy the full SHA 5b136abView commit details -
The new weights for the individual sub-projects are their duration in seconds.
Configuration menu - View commit details
-
Copy full SHA for 3222e60 - Browse repository at this point
Copy the full SHA 3222e60View commit details
Commits on Mar 6, 2024
-
Previously, all flash messages were showing with the same (black) background. Internally, the flash object converts and stores keys as strings [1]. [1] https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/middleware/flash.rb#L163
Configuration menu - View commit details
-
Copy full SHA for 991a179 - Browse repository at this point
Copy the full SHA 991a179View commit details -
Merge pull request #5678 from mamhoff/legacy-promotions-gem
Add Legacy promotions gem
Configuration menu - View commit details
-
Copy full SHA for cb4ec7b - Browse repository at this point
Copy the full SHA cb4ec7bView commit details -
Merge pull request #5677 from mamhoff/promotion-finder
Add extension point: Promotion finder
Configuration menu - View commit details
-
Copy full SHA for d5dd8b6 - Browse repository at this point
Copy the full SHA d5dd8b6View commit details -
Fix JS locale data for release of Money 6.19
The money gem in its latest iteration added a space between value and unit of the Swiss Franc. Our heuristic in `_js_locale_data.html.erb` can't deal with that, so we add a third branch to it: If the money gem has a format wish, we'll respect it, but replace its abbreviations with the one the `accounting.js` library prefers.
Configuration menu - View commit details
-
Copy full SHA for f19e6fc - Browse repository at this point
Copy the full SHA f19e6fcView commit details
Commits on Mar 7, 2024
-
Merge pull request #5683 from mamhoff/fix-money-6.19
Fix JS locale data for release of Money 6.19
Configuration menu - View commit details
-
Copy full SHA for 885a453 - Browse repository at this point
Copy the full SHA 885a453View commit details -
Merge pull request #5681 from nebulab/spaghetticode/fix-admin-flash
[ADMIN] Fix flash messages coloring
Configuration menu - View commit details
-
Copy full SHA for 75d3196 - Browse repository at this point
Copy the full SHA 75d3196View commit details