[pull] main from solidusio:main #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This is intended to be used by the API Promotions Controller.
This configurable class finds a promotion by its code.
The default has to be the Null promotion finder.
The API promotions controller is pretty straightforward, and the only touch point here is finding a promotion. With that added to the promotion configuration, we can now use it with no changes to our specs.
This allows us to change the promotion system with factories, because we stop using factories in this spec.
We want to extract the legacy promotion system from Solidus into its own gem to facilitate moving towards solidus_promotions.
The new weights for the individual sub-projects are their duration in seconds.
Previously, all flash messages were showing with the same (black) background. Internally, the flash object converts and stores keys as strings [1]. [1] https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/middleware/flash.rb#L163
Add Legacy promotions gem
Add extension point: Promotion finder
pull
bot
added
⤵️ pull
and removed
changelog:repository
changelog:solidus_api
changelog:solidus_core
changelog:solidus
labels
The money gem in its latest iteration added a space between value and unit of the Swiss Franc. Our heuristic in `_js_locale_data.html.erb` can't deal with that, so we add a third branch to it: If the money gem has a format wish, we'll respect it, but replace its abbreviations with the one the `accounting.js` library prefers.
Fix JS locale data for release of Money 6.19
[ADMIN] Fix flash messages coloring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )