[pull] main from solidusio:main #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Without this, engines that want to display the Solidus menu bar will get an error.
We've already deprecated Spree::Adjustment#calculate_eligibility, and we've removed all the code paths that call Spree::Adjustment#recalculate. Let's deprecate it.
This promotion isn't necessary for testing the rounding here. We can just use a manual adjustment.
We want to move the order_with_promotion factory.
We need this ability across several gems in the future.
This allows to check for working factories outside the core gem.
…ration We want to be able to move all promotion-related things out of `solidus_core` in PR #5634. However, Spree::AppConfiguration also does all the promotion-specific things, and we can't move the app configuration out of core. In #5658, we've added a promotion configuration object as a nucleus for core's promotion system's configuration, `Spree::Core::PromotionConfiguration`. This implements all the promotion-specific configuration preferences from `Spree::AppConfiguration` there.
This implements deprecated setters and getters for the promotion-specific preferences on `Spree::AppConfiguration`. Now, if a developer wants to set their
The contents of this class are promotion-related and should move to `Spree::PromotionConfiguration`. We can also use the default option of the `add_class_set` method here. There were originally no direct specs for `Spree::Core::Environment::Promotions`. I'm not adding any, because the class is indirectly tested through `Spree::AppConfiguration` and now only has deprecated methods.
It's working!
It seems we want to be able to test files without loading all of Solidus. Unfortunately, we do load Solidus' configuration, and this PR needs the configuration object to be able to deprecate extension points. What this commit does is it allows loading a module that defined `Spree.deprecator` and loads that module in both `spree/core.rb` and the `spec_helper.rb`.
This is an extension point to tell adjustments about what type of adjustments they are. For the new solidus_friendly_promotions gems, we need a different type from the `Spree::PromotionAction`. This is not part of the promotion configuration object, because it is very much thinkable to have historical adjustments with promotion sources from a different promotion extension.
Rather than hardcoding `Spree::PromotionAction` here, use the configured promotion source types.
…-promotion-adjustment-sources Configurable promotion adjustment sources
Promotion configuration
…cellation-spec Remove promotion from cancellations spec
pull
bot
added
⤵️ pull
and removed
changelog:solidus_backend
changelog:solidus_api
changelog:solidus_core
labels
Spree::Core::PromotionConfiguration will have to live in the solidus_legacy_promotions gem. We will need a stand-in! But for that stand-in, we also need an extension point.
This allows us to have a stand-in for a promotion system when, in fact, we don't have one.
This is a stand-in for all the promotion handlers we have. It implements all the methods from the promotion handler "coupon".
We need a promotion configuration when solidus_legacy_promotions is out of core. This provides it.
Introduce a null promotion configuration
…ed-examples Make shared examples and DummyAbility require-able from outside of core
…-routing-proxy Use routing proxy in locale selection
Deprecate Spree::Adjustment#recalculate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )