Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use routing proxy in locale selection #5611

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jan 22, 2024

Summary

Without this, engines that want to display the Solidus menu bar will get an error.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

Without this, engines that want to display the Solidus menu bar will get
an error.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69090d5) 88.57% compared to head (5eabcfe) 88.57%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5611   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files         685      685           
  Lines       16405    16405           
=======================================
  Hits        14531    14531           
  Misses       1874     1874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen added the backport-v4.3 Backport this pull-request to v4.3 label Jan 22, 2024
@tvdeyen tvdeyen merged commit b532f94 into solidusio:main Feb 27, 2024
16 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.3 Backport this pull-request to v4.3 changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants