Repository navigation
fix(webui): complete i18n coverage for exposed routes - #7052
Conversation
italic-jinxin
added
size: XL
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
🚅 Deployed to the ironclaw-pr-7052 environment in ironclaw-ci-preview
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe WebUI localization packs now translate extension, custom MCP, artifact download, and web pairing strings across ten non-English locales. Tests verify key completeness, interpolation parity, and extension workflow localization. ChangesWebUI localization
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
italic-jinxin
added
the
skip-regression-check
🔎 Review · PR #7052
Submitted review →Reviewed the complete trusted base-to-head comparison. The ten locale packs consistently add or update the intended WebUI translations, preserve interpolation parameters, and share the same changed key set. The expanded locale contract tests are appropriate. No concrete actionable findings were identified. Automatic · PR opened + CI failed · attempt 1 of 3 · completed in 2m 17s Run details
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/ironclaw_webui/frontend/src/lib/i18n.test.ts`:
- Around line 118-142: Extend the extensionWorkflowKeys selection in the
“non-English locale packs localize exposed extension workflow copy” test to
include chat.downloadRunArtifact, chat.downloadThreadArtifact, and every key
starting with pairing.web., while preserving the existing technicalTerms
exclusions and localization assertions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0e4315c8-6b30-487a-a23f-50f9180d0b32
📒 Files selected for processing (11)
crates/ironclaw_webui/frontend/src/i18n/ar.tscrates/ironclaw_webui/frontend/src/i18n/de.tscrates/ironclaw_webui/frontend/src/i18n/es.tscrates/ironclaw_webui/frontend/src/i18n/fr.tscrates/ironclaw_webui/frontend/src/i18n/hi.tscrates/ironclaw_webui/frontend/src/i18n/ja.tscrates/ironclaw_webui/frontend/src/i18n/ko.tscrates/ironclaw_webui/frontend/src/i18n/pt-BR.tscrates/ironclaw_webui/frontend/src/i18n/uk.tscrates/ironclaw_webui/frontend/src/i18n/zh-CN.tscrates/ironclaw_webui/frontend/src/lib/i18n.test.ts
![ironloopai[bot]](https://avatars.githubusercontent.com/in/4116490?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Review complete · PR #7052
✅ No actionable findings
Reviewed the complete trusted base-to-head comparison. The ten locale packs consistently add or update the intended WebUI translations, preserve interpolation parameters, and share the same changed key set. The expanded locale contract tests are appropriate. No concrete actionable findings were identified.
Validation and technical details
- Inspected all 11 changed files and surrounding i18n loader, interpolation, and affected UI call sites.
- Confirmed every non-English locale changes the same key set.
pnpm exec vitest run src/lib/i18n.test.ts: 25 tests passed.pnpm typecheck: passed; environment warned that Node 24.18.0 differs from the supported Node 22 line.git diff --check refs/ironloop/base..refs/ironloop/head: passed.- Base:
main - Head:
issue-7051-webui-i18n-coverageatc4dca51 - Run:
41d099c1-9768-40a2-94c9-7f439759b6ed
|
@claude review |
italic-jinxin
removed
the
skip-regression-check
* fix(webui): complete i18n coverage for exposed flows * test(webui): enforce translations for exposed workflows * test(webui): make i18n regression assertion detectable
This branch was successfully deployed
2 participants
Summary
Change Type
Linked Issue
Closes #7051
Validation
pnpm exec vitest run src/lib/i18n.test.ts— 25 tests passedenv TZ=UTC pnpm test— 1,044 tests passedpnpm typecheckpnpm lint:conventionspnpm build— production build and bundle budgets passedgit diff --checkcargo test -p ironclaw_webui --all-features— compiled successfully; 188 tests passed and 21 OAuth/mock HTTP tests were blocked by the local environment returning502 Bad Gatewayfor loopback requestsTest Strategy
User behavior:
Users selecting a non-English locale see localized navigation, chat artifact download actions, channel pairing instructions, and custom MCP registration copy instead of English fallback text.
Risk areas:
Tests added or updated:
What the tests prove:
Every supported non-English locale covers the full English key set, preserves all interpolation parameters, and does not retain English fallback copy for exposed Extensions/MCP workflow strings.
Commands run:
pnpm exec vitest run src/lib/i18n.test.tspnpm typecheckpnpm lint:conventionsenv TZ=UTC pnpm testpnpm buildgit diff --checkcargo test -p ironclaw_webui --all-featuresSecurity Impact
None. This changes static presentation strings and locale contract tests only.
Reborn Trust-Boundary Checklist
N/A: no trust boundaries, authorization, persistence, runtime execution, network behavior, or public contracts changed.
Database Impact
None. No schema, migration, or persistence behavior changes.
Blast Radius
Limited to WebUI locale packs and i18n contract tests. English copy and application behavior are unchanged.
Rollback Plan
Revert this PR to restore the previous locale packs and selected-key i18n tests.
Review Follow-Through
A native-speaker review of the new translations would be useful but is not required for functional correctness. No known technical follow-up remains.
Review track: A