Repository navigation
fix(webui): localize v2 tools and extensions copy - #5401
Conversation
italic-jinxin
added
size: XL
|
@claude review |
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughAdds new Changesi18n keys and UI localization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/ironclaw_webui_v2_static/static/js/i18n/hi.js`:
- Line 521: The Hindi translation for tools.description.builtin.trigger_pause
contains an Arabic word (محفوظ) that should be replaced with a proper Hindi
equivalent. Update the string in hi.js to use a natural Hindi phrase such as
बनाए रखा or सुरक्षित, keeping the rest of the translation intact and ensuring
the sentence remains fluent for Hindi readers.
In
`@crates/ironclaw_webui_v2_static/static/js/pages/settings/components/tools-tab.js`:
- Around line 11-15: The translatedToolDescription helper is returning an empty
string too early when tool.description is missing, which hides valid localized
text. Remove the initial tool.description guard in translatedToolDescription and
always try the tools.description.${tool.name} lookup first, falling back to
tool.description only if the translation is missing or unchanged; keep the
existing behavior in the tools-tab row copy and translated-search path by
relying on this helper’s translation-first flow.
- Around line 231-242: The search filter in tools-tab.js is incorrectly treating
every locked tool as “disabled” by using tool.locked ? t("tools.disabled") : ""
inside the matchesSearch array. Update the filtering logic in the filtered tools
callback so locked status is not indexed as the disabled label, and instead rely
on the actual tool.state/tool.default_state/tool.effective_source fields (and
any explicit disabled state text) to determine search matches. Keep the change
localized to the filter in the tools-tab component so locked-but-enabled tools
no longer match searches for “disabled”.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ce154bd2-ff3f-4a5c-aa66-70ef85afb413
📒 Files selected for processing (20)
crates/ironclaw_webui_v2_static/static/js/i18n/ar.jscrates/ironclaw_webui_v2_static/static/js/i18n/de.jscrates/ironclaw_webui_v2_static/static/js/i18n/en.jscrates/ironclaw_webui_v2_static/static/js/i18n/es.jscrates/ironclaw_webui_v2_static/static/js/i18n/fr.jscrates/ironclaw_webui_v2_static/static/js/i18n/hi.jscrates/ironclaw_webui_v2_static/static/js/i18n/ja.jscrates/ironclaw_webui_v2_static/static/js/i18n/ko.jscrates/ironclaw_webui_v2_static/static/js/i18n/pt-BR.jscrates/ironclaw_webui_v2_static/static/js/i18n/uk.jscrates/ironclaw_webui_v2_static/static/js/i18n/zh-CN.jscrates/ironclaw_webui_v2_static/static/js/pages/extensions/components/channels-tab.jscrates/ironclaw_webui_v2_static/static/js/pages/extensions/components/configure-modal.jscrates/ironclaw_webui_v2_static/static/js/pages/extensions/components/extension-card.jscrates/ironclaw_webui_v2_static/static/js/pages/extensions/components/extension-card.test.mjscrates/ironclaw_webui_v2_static/static/js/pages/extensions/hooks/useExtensions-catalog.test.mjscrates/ironclaw_webui_v2_static/static/js/pages/extensions/hooks/useExtensions-pairing.test.mjscrates/ironclaw_webui_v2_static/static/js/pages/extensions/hooks/useExtensions.jscrates/ironclaw_webui_v2_static/static/js/pages/settings/components/tools-tab.jscrates/ironclaw_webui_v2_static/static/js/pages/settings/components/tools-tab.test.mjs
|
🚅 Deployed to the ironclaw-pr-5401 environment in ironclaw-ci-preview
|
This branch was successfully deployed
2 participants
Summary
builtin.*tools in the Settings > Tools permission list, including Trace Commons, memory, file, shell, skill, and trigger capabilities.Validation
node --test crates/ironclaw_webui_v2_static/static/js/pages/extensions/components/extension-card.test.mjs crates/ironclaw_webui_v2_static/static/js/pages/extensions/components/channels-tab.test.mjs crates/ironclaw_webui_v2_static/static/js/pages/extensions/hooks/useExtensions-catalog.test.mjs crates/ironclaw_webui_v2_static/static/js/pages/extensions/hooks/useExtensions-pairing.test.mjs crates/ironclaw_webui_v2_static/static/js/pages/settings/components/tools-tab.test.mjsnode crates/ironclaw_webui_v2_static/frontend/build.mjscargo test -p ironclaw_webui_v2_staticgit diff --checkSecurity Impact
No. UI-only localization changes; no auth, approval, network, secret, or execution behavior changes.
Database Impact
No schema or migration changes.
Blast Radius
Limited to
crates/ironclaw_webui_v2_staticstatic WebUI v2 copy, locale packs, and focused JS tests.Rollback Plan
Revert this PR to restore the previous backend-provided English descriptions and hardcoded WebUI v2 extension copy.
Review track: C