Conversation
⏳ IronLoop Review StatusHead: Current reviewers:
Reviewer summaries
Recent activity
Available commands
Run metadataAdmission: webhook accepted the request and IronLoop persisted review state before this projection. |
github-actions
Bot
added
scope: ci
![ironloopai[bot]](https://avatars.githubusercontent.com/in/4116490?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ IronLoop Review: reviewer
Verdict: ❌ Changes requested
Findings: 1 blocking / 0 notes
Next: Fix the blocking findings, push the PR branch, then re-run this reviewer.
Head: 54e66d93570c1842ec8374de6f3c63deb4dfbac8
Run details
Status: Current
Needs human: no
Needs validation: no
Summary
The pnpm migration is incomplete for GitHub Actions: the workflows ask setup-node to restore a pnpm cache before pnpm is made available, so the affected CI jobs can fail before reaching the new Corepack step.
Findings
1. ❌ [MEDIUM] Enable pnpm before setup-node cache restore
Location: .github/workflows/reborn-playwright.yml:84-85
The workflow now sets cache: "pnpm" on actions/setup-node, but pnpm is only enabled in the following step. setup-node's pnpm cache restore needs the pnpm executable during the setup-node action itself to resolve the store path, so clean runners can fail here before corepack enable pnpm runs. The same ordering appears in the other updated workflows (code_style.yml, coverage.yml, platform-and-compat.yml, reborn-e2e.yml, and reborn-tests.yml). Move Corepack/pnpm setup before the cached setup-node step, or use a pnpm setup action before setup-node.
Developer follow-up
After fixing this feedback:
- Push the fix to this PR branch.
- Re-run this reviewer with
@ironloop review --agent reviewerif you only changed this reviewer's findings. - Re-run all reviewers with
@ironloop reviewwhen the fix may affect multiple areas. - Use
@ironloop statusto check queued/running/completed/stale/stalled state while reviewers run.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the frontend package manager from npm to pnpm (v11), updating the Rust build script, the shell build scripts, package configuration, and lockfiles accordingly. The review feedback points out that the onlyBuiltDependencies configuration in pnpm-workspace.yaml is redundant and should be removed, as it has been replaced by allowBuilds in pnpm v11.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Caution Review failedAn error occurred during the review process. Please try again later. 📝 WalkthroughSummary by CodeRabbit
WalkthroughWebUI tooling for Changesnpm to pnpm migration
E2E failure category update
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
54e66d9 to
ea68a58
Compare
9a0e643 to
41d8568
Compare
|
@coderabbitai full review |
🗂️ Archived IronLoop Review: reviewerThis result is from an older PR head and is no longer the active review.
Archived summaryNo blocking issues found in the pnpm migration for the WebUI v2 frontend build, CI cache setup, or Docker build environment. |
✅ Action performedFull review finished. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/ironclaw_webui_v2/frontend/pnpm-workspace.yaml`:
- Around line 4-8: Remove the obsolete pnpm workspace setting by updating the
pnpm-workspace config to keep only allowBuilds and drop onlyBuiltDependencies.
The affected config is the workspace file containing esbuild, and the relevant
symbol to locate is allowBuilds; make sure pnpm 11.7.0-compatible config remains
valid by deleting the deprecated onlyBuiltDependencies entry entirely.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8bca4bec-39b7-46ec-afb3-10330b9d1c2d
⛔ Files ignored due to path filters (2)
crates/ironclaw_webui_v2/frontend/package-lock.jsonis excluded by!**/package-lock.jsoncrates/ironclaw_webui_v2/frontend/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
.github/workflows/code_style.yml.github/workflows/coverage.yml.github/workflows/platform-and-compat.yml.github/workflows/reborn-e2e.yml.github/workflows/reborn-playwright.yml.github/workflows/reborn-tests.ymlcrates/ironclaw_webui_v2/build.rscrates/ironclaw_webui_v2/frontend/build.shcrates/ironclaw_webui_v2/frontend/package.jsoncrates/ironclaw_webui_v2/frontend/pnpm-workspace.yaml
41d8568 to
0d8a914
Compare
ea68a58 to
3f757b3
Compare
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
@IronLoop review |
3f757b3 to
4dd8d78
Compare
|
@IronLoop review |
|
@coderabbitai full review |
✅ Action performedFull review finished. Your plan includes PR reviews subject to rate limits. More reviews will be available in 49 minutes. |
c794009 to
352a2cc
Compare
e04cf9d to
283f884
Compare
|
/canary |
|
Started Reborn WebUI v2 live canary for |
|
/canary |
|
Started Reborn WebUI v2 live canary for |
serrrfirat
left a comment
serrrfirat
left a comment
There was a problem hiding this comment.
Reviewed with code-review-multi lenses plus thermo maintainability pass.
No blocking findings. I inspected the pnpm workflow/Docker/build.rs changes and ran targeted frontend checks in the detached PR worktree:
- corepack pnpm install --frozen-lockfile passed
- corepack pnpm build passed (legacy esbuild bundle path for this stack slice)
354beb7 to
171403b
Compare
Coverage ratchetReborn integration-tier coverageLine coverage (Reborn crates): 85.32% — 279173 / 327196 lines Per-crate breakdown (65 crates, lowest-covered first)
This table itself is informational and never gates the PR on its own — not the percentage, not the per-crate holes, not the 0-coverage callout. A separate coverage ratchet (dry-run until enforce=true; see tests/integration/coverage-floor.toml) can fail the build on specific configured floors. Exemptions (4 entry/entries excluded from the accounting above)
|
|
All review threads are resolved on the current head e64bcde. Regular PR CI is green, and standalone Reborn Playwright passed after rerunning the transient apt/NOSPLIT setup failure: https://github.com/nearai/ironclaw/actions/runs/28900082895. Auto-merge is enabled but blocked on the required non-author approval. |
|
Superseded by #5732, which now contains the combined WebUI frontend stack against main. |
This branch was successfully deployed
3 participants
Summary
pnpm-lock.yaml/pnpm-workspace.yamland remove the npm lockfile.Verification
pnpm install --frozen-lockfilepnpm build(legacy build at this layer)cargo check -p ironclaw_webui_v2 --features webui-v2-betagit diff --check,pnpm typecheck,pnpm test,pnpm build,cargo test -p ironclaw_webui_v2 --features webui-v2-beta, andcargo test -p ironclaw_reborn_composition --features webui-v2-beta --test webui_v2_serve.