[codex] Add Reborn Playwright workflow - #5449
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds a new GitHub Actions workflow ( ChangesReborn Playwright CI Workflow
No invariant docs (CLAUDE.md/AGENTS.md/.claude/rules) referenced in diff to check against. Flagging anyway, since this is CI-as-code, not Rust:
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
63d0d65 to
652eb34
Compare
|
🚅 Deployed to the ironclaw-pr-5449 environment in ironclaw-ci-preview
|
652eb34 to
63fe9cd
Compare
63fe9cd to
5d5f457
Compare
|
Initial timing from the passing
Takeaway: the Playwright browser tests are cheap once binaries exist; the PR cost is dominated by the shared Rust build. If we want this as required PR CI, the next optimization target is reusing an existing warm Reborn build/cache or only running this workflow where another job has already built the same binary. |
5d5f457 to
7a95b92
Compare
|
Correction: removed the earlier |
7a95b92 to
be70f67
Compare
|
Updated: moved |
Summary
Adds a separate nightly
Reborn Playwrightworkflow for standalone Reborn browser scenarios.The workflow:
workflow_dispatchironclaw-rebornWebUI binary once--durations=25test_reborn_legacy_always_approve_survives_reborn_restart, which is a server restart persistence test rather than a browser timing test and timed out in the first measurement runValidation
scripts/ci/check-e2e-matrix-files.sh .github/workflows/reborn-playwright.ymlruby -e 'require "yaml"; YAML.load_file(".github/workflows/reborn-playwright.yml"); puts "yaml ok"'webui-smoke-files: 14 testslegacy-core-ui: 19 testslegacy-auth-inputs: 31 testslegacy-settings-extensions: 58 selected / 59 collected, 1 deselectedlegacy-runtime: 31 testsNotes
Earlier measurement showed the Playwright shards are short, but the shared Rust build dominates wall time. This PR keeps the suite out of normal PR CI and makes it nightly/manual instead.