Skip to content

ci: retire dormant reborn-integration workflow, add Reborn suites to nightly deep CI - #4829

Merged
serrrfirat merged 3 commits into
mainfrom
claude/goofy-williamson-089670
Jun 20, 2026
Merged

serrrfirat merged 3 commits into
mainfrom
claude/goofy-williamson-089670

Conversation

@serrrfirat

@serrrfirat serrrfirat commented Jun 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Delete .github/workflows/reborn-integration.yml: it only triggered on the dormant reborn-integration branch, so it has not run for any main-targeted work. Its three jobs (Reborn crate-family package matrix, per-crate tests, 4-partition root parity tests) are byte-for-byte duplicates of what reborn-tests.yml already runs on every PR, merge queue entry, and main push — retiring it loses no coverage.
  • Drop the stale reborn-integration.yml entry from scripts/ci/classify-test-scope.sh.
  • Add the Reborn suites to Nightly Deep CI: previously nightly only called the legacy test.yml, so the Reborn binary had no scheduled safety net. Wires in reborn-tests.yml (per-crate tests + root parity partitions; scope detection short-circuits to full scope for non-PR events) and reborn-e2e.yml (deterministic Rust contract gate + gateway and WebUI v2 Playwright smoke; workflow_call bypasses the PR path filters so the full gate runs).
  • The existing nightly alert job now opens/updates its failure issue if any of the three suites fails (combined-result expression); failed-job logs flow through unchanged since reusable-workflow jobs belong to the caller's run.

Change Type

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • CI/Infrastructure
  • Security
  • Dependencies

Linked Issue

None.

Validation

  • cargo fmt --all -- --check — N/A, no Rust changes
  • cargo clippy --all --benches --tests --examples --all-features -- -D warnings — N/A, no Rust changes
  • cargo build — N/A, no Rust changes
  • Relevant tests pass: bash scripts/ci/test-classify-test-scope.sh (all cases PASS)
  • cargo test --features integration — N/A, no database-backed behavior changed
  • Manual testing: python3 yaml.safe_load parses the edited workflow; grep -r reborn-integration confirms no remaining workflow/script references (docs mentions are historical plan documents)
  • Both Reborn workflows already declare workflow_call with a ref input and use inputs.ref || github.sha in every checkout, need no secrets, and pass today on every Reborn PR — same reuse pattern Nightly Deep CI already uses for test.yml

Not verified live: an actual scheduled nightly dispatch. workflow_dispatch on nightly-deep-ci can dry-run it after merge.

Security Impact

None. permissions: contents: read unchanged; the alert job's existing scoped permissions are untouched.

Reborn Trust-Boundary Checklist

N/A — CI workflow wiring only, no Rust/runtime/DB changes.

Database Impact

None.

Blast Radius

CI only: Nightly Deep CI workflow, scope-classifier shared-path list, and removal of a workflow that never ran on main-targeted refs. No PR-gating or merge-queue behavior changes.

Rollback Plan

Revert the single commit — restores reborn-integration.yml and the previous nightly job set.

🤖 Generated with Claude Code

…nightly deep CI

The reborn-integration workflow only triggered on the long-dead
reborn-integration branch and duplicated reborn-tests.yml job-for-job
(same crate-family matrix, same root parity partitions), so it never
ran for main-targeted work. Delete it and drop its entry from the
shared-path classifier.

Nightly Deep CI previously covered only the legacy test.yml suite,
leaving the Reborn binary with no scheduled safety net. Wire in
reborn-tests.yml and reborn-e2e.yml via workflow_call (both already
support it with a ref input) and fold their results into the existing
alert-issue job.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added size: L 200-499 changed lines risk: medium Business logic, config, or moderate-risk modules scope: ci CI/CD workflows labels Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Nightly deep CI workflow integrates Reborn tests as mandatory gates by adding reborn-tests and reborn-e2e jobs and updating alert aggregation to require success across all three test suites. Legacy reborn-integration.yml references are removed from CI scope classification.

Changes

Consolidate Reborn Tests into Nightly CI

Layer / File(s) Summary
Nightly workflow augmentation with Reborn test gates
.github/workflows/nightly-deep-ci.yml
New reborn-tests and reborn-e2e jobs call reusable Reborn workflows; nightly-alert now depends on all three test suites and computes ALERT_RESULT as success only when deterministic-deep-tests, reborn-tests, and reborn-e2e all report success.
Legacy workflow reference cleanup
scripts/ci/classify-test-scope.sh
Scope classifier pattern excludes .github/workflows/reborn-integration.yml from shared test paths.

🔄 Three gates now dance in sync,
Nightly vigil guards the brink,
Old pipelines fade to black,
One strong flow takes the track. ✨


🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed Title follows Conventional Commits style with type(scope): summary format and accurately describes both major changes—retiring reborn-integration and adding Reborn suites to nightly CI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed PR description is comprehensive and follows the template structure with all critical sections completed: Summary (5 bullets covering the changes), Change Type (CI/Infrastructure selected), Validation (with detailed test results), Security Impact, Blast Radius, and Rollback Plan clearly documented.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the contributor: core 20+ merged PRs label Jun 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the scripts/ci/classify-test-scope.sh script by removing .github/workflows/reborn-integration.yml from the list of shared test paths in the is_shared_test_path function. There are no review comments, and we have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

…on-089670

# Conflicts:
#	.github/workflows/reborn-integration.yml
…on-089670

# Conflicts:
#	.github/workflows/reborn-integration.yml
@serrrfirat
serrrfirat merged commit c50edb9 into main Jun 20, 2026
68 checks passed
@serrrfirat
serrrfirat deleted the claude/goofy-williamson-089670 branch June 20, 2026 20:53
theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026
…nightly deep CI (nearai#4829)

The reborn-integration workflow only triggered on the long-dead
reborn-integration branch and duplicated reborn-tests.yml job-for-job
(same crate-family matrix, same root parity partitions), so it never
ran for main-targeted work. Delete it and drop its entry from the
shared-path classifier.

Nightly Deep CI previously covered only the legacy test.yml suite,
leaving the Reborn binary with no scheduled safety net. Wire in
reborn-tests.yml and reborn-e2e.yml via workflow_call (both already
support it with a ref input) and fold their results into the existing
alert-issue job.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: ci CI/CD workflows size: L 200-499 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant