ci: retire dormant reborn-integration workflow, add Reborn suites to nightly deep CI - #4829
Conversation
…nightly deep CI The reborn-integration workflow only triggered on the long-dead reborn-integration branch and duplicated reborn-tests.yml job-for-job (same crate-family matrix, same root parity partitions), so it never ran for main-targeted work. Delete it and drop its entry from the shared-path classifier. Nightly Deep CI previously covered only the legacy test.yml suite, leaving the Reborn binary with no scheduled safety net. Wire in reborn-tests.yml and reborn-e2e.yml via workflow_call (both already support it with a ref input) and fold their results into the existing alert-issue job. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughNightly deep CI workflow integrates Reborn tests as mandatory gates by adding ChangesConsolidate Reborn Tests into Nightly CI
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the scripts/ci/classify-test-scope.sh script by removing .github/workflows/reborn-integration.yml from the list of shared test paths in the is_shared_test_path function. There are no review comments, and we have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…on-089670 # Conflicts: # .github/workflows/reborn-integration.yml
…on-089670 # Conflicts: # .github/workflows/reborn-integration.yml
…nightly deep CI (nearai#4829) The reborn-integration workflow only triggered on the long-dead reborn-integration branch and duplicated reborn-tests.yml job-for-job (same crate-family matrix, same root parity partitions), so it never ran for main-targeted work. Delete it and drop its entry from the shared-path classifier. Nightly Deep CI previously covered only the legacy test.yml suite, leaving the Reborn binary with no scheduled safety net. Wire in reborn-tests.yml and reborn-e2e.yml via workflow_call (both already support it with a ref input) and fold their results into the existing alert-issue job. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Summary
.github/workflows/reborn-integration.yml: it only triggered on the dormantreborn-integrationbranch, so it has not run for any main-targeted work. Its three jobs (Reborn crate-family package matrix, per-crate tests, 4-partition root parity tests) are byte-for-byte duplicates of whatreborn-tests.ymlalready runs on every PR, merge queue entry, and main push — retiring it loses no coverage.reborn-integration.ymlentry fromscripts/ci/classify-test-scope.sh.test.yml, so the Reborn binary had no scheduled safety net. Wires inreborn-tests.yml(per-crate tests + root parity partitions; scope detection short-circuits to full scope for non-PR events) andreborn-e2e.yml(deterministic Rust contract gate + gateway and WebUI v2 Playwright smoke;workflow_callbypasses the PR path filters so the full gate runs).Change Type
Linked Issue
None.
Validation
cargo fmt --all -- --check— N/A, no Rust changescargo clippy --all --benches --tests --examples --all-features -- -D warnings— N/A, no Rust changescargo build— N/A, no Rust changesbash scripts/ci/test-classify-test-scope.sh(all cases PASS)cargo test --features integration— N/A, no database-backed behavior changedpython3 yaml.safe_loadparses the edited workflow;grep -r reborn-integrationconfirms no remaining workflow/script references (docs mentions are historical plan documents)workflow_callwith arefinput and useinputs.ref || github.shain every checkout, need no secrets, and pass today on every Reborn PR — same reuse pattern Nightly Deep CI already uses fortest.ymlNot verified live: an actual scheduled nightly dispatch.
workflow_dispatchon nightly-deep-ci can dry-run it after merge.Security Impact
None.
permissions: contents: readunchanged; the alert job's existing scoped permissions are untouched.Reborn Trust-Boundary Checklist
N/A — CI workflow wiring only, no Rust/runtime/DB changes.
Database Impact
None.
Blast Radius
CI only: Nightly Deep CI workflow, scope-classifier shared-path list, and removal of a workflow that never ran on main-targeted refs. No PR-gating or merge-queue behavior changes.
Rollback Plan
Revert the single commit — restores
reborn-integration.ymland the previous nightly job set.🤖 Generated with Claude Code