Repository navigation
feat(reborn): route Responses through ProductWorkflow - #4546
Merged
Merged
Conversation
…nai-api-contracts
…nai-api-contracts
…reborn-chat-completions-workflow
* feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com>
github-actions
Bot
added
scope: docs
…ns-workflow' into issue-4445-reborn-responses-workflow # Conflicts: # docs/reborn/contracts/openai-compatible-api.md
…t-completions-workflow
…ns-workflow' into issue-4445-reborn-responses-workflow # Conflicts: # crates/ironclaw_reborn_openai_compat/src/chat_workflow.rs
…-4445-reborn-responses-workflow
Base automatically changed from
issue-4444-reborn-chat-completions-workflow
to
main
June 9, 2026 10:46
…ponses-workflow # Conflicts: # crates/ironclaw_reborn_composition/src/openai_compat_serve.rs # crates/ironclaw_reborn_composition/tests/webui_v2_serve.rs # crates/ironclaw_reborn_openai_compat/CLAUDE.md # crates/ironclaw_reborn_openai_compat/src/chat_workflow.rs # crates/ironclaw_reborn_openai_compat/src/handlers.rs # crates/ironclaw_reborn_openai_compat/src/lib.rs # docs/reborn/contracts/openai-compatible-api.md
think-in-universe
dismissed
henrypark133’s stale review
June 9, 2026 11:08
Review comments are resolved
think-in-universe
enabled auto-merge
June 9, 2026 11:08
hanakannzashi
approved these changes
Jun 9, 2026
think-in-universe
removed this pull request from the merge queue due to a manual request
Jun 9, 2026
theredspoon
pushed a commit
to theredspoon/ironclaw
that referenced
this pull request
Jun 21, 2026
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * feat(reborn): route chat completions through ProductWorkflow * fix(reborn): simplify chat completion timestamps * fix(reborn): use explicit ProductWorkflow submit door * test(reborn): stabilize subagent cancellation propagation * Validate durable OpenAI compat ref records * Fix chat completions idempotency validation * Format OpenAI compat storage review fixes * feat(reborn): add OpenAI-compatible product refs (nearai#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> * Address chat completions review comments * Persist chat completion idempotency replay metadata * Export OpenAI compat ack recording request * Persist OpenAI compat accepted workflow acks * feat(reborn): route responses through ProductWorkflow * fix(reborn): declare compat storage chrono dependency * fix(reborn): resolve chat completions review feedback * fix(reborn): resolve chat completions review feedback * fix(reborn): keep responses cancel within adapter boundary * fix(openai-compat): address chat workflow review comments * fix(openai-compat): address responses handler review comments * fix(openai-compat): persist responses replay state * test(openai-compat): cover responses review paths * fix(openai-compat): annotate optional responses router state * test(product-adapters): cover cancel run payload validation * fix(openai-compat): address chat ref store review * fix(reborn): resolve chat projections through workflow * fix(reborn): close responses workflow review gaps * test(reborn): cover responses wait cancellation * feat(reborn): wire OpenAI chat completions route * fix(reborn): wire OpenAI responses composition * fix(reborn): centralize chat body validation * fix(reborn): centralize responses body validation * fix(reborn): keep OpenAI compat off turns --------- Co-authored-by: Coffee <zjchen1234@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAiResponsesWorkflowfor non-streaming Responses create, retrieve, and cancel routes./api/v1/responses,/v1/responses, retrieve, and cancel handlers through injected ProductWorkflow/projection-reader state instead of fail-closed stubs.resp_*refs, actor-scoped idempotency replay/conflict behavior, previous-response authorization, timeout-detach semantics, and sanitized not-found behavior for nonexistent/unauthorized/unbound refs.stream: true, requesttools, andtool_choicerejected before ProductWorkflow side effects; streaming remains the [Reborn] Translate projection streams to OpenAI-compatible SSE #4446 slice.Linked Issue
Refs #4445
Depends on #4444
Part of #3283
Validation
cargo fmt --all -- --checkgit diff --checkcargo test -p ironclaw_reborn_openai_compat --features openai-compat-beta --ignore-rust-versioncargo test -p ironclaw_reborn_openai_compat_storage --all-features --ignore-rust-versionSecurity Impact
Yes. This touches authenticated API route behavior and cancellation. The route requires host-minted authenticated caller state, authorizes
previous_response_idand retrieve/cancel refs through the opaque ref store, rejects unsupported tools/streaming before side effects, caps flattened input items before ProductWorkflow side effects, sanitizes flattened input text to prevent newline role injection, and returns the same sanitized not-found shape for nonexistent, unauthorized, or unbound refs.Database Impact
No schema or migration changes. This uses the existing OpenAI-compatible ref store port and projection-reader seam.
Blast Radius
Limited to
ironclaw_reborn_openai_compatbehindopenai-compat-beta, plus the Reborn OpenAI-compatible API contract doc. Streaming remains fail-closed for #4446.Rollback Plan
Revert this PR to return Responses create/retrieve/cancel routes to their prior fail-closed
501 unsupportedbehavior.Review Follow-Through
Reviewer judgment requested on the temporary projection-reader seam and the ProductWorkflow control-action acknowledgement shape for cancel. The route accepts both accepted and command-result acknowledgements for cancel while keeping create strict.
Review track: C