Skip to content

feat(reborn): add OpenAI-compatible product refs - #4489

Merged
serrrfirat merged 5 commits into
issue-4442-reborn-openai-api-contractsfrom
issue-4443-reborn-openai-product-refs
Jun 8, 2026
Merged

serrrfirat merged 5 commits into
issue-4442-reborn-openai-api-contractsfrom
issue-4443-reborn-openai-product-refs

Conversation

@hanakannzashi

Copy link
Copy Markdown
Contributor

Summary

  • Added typed opaque OpenAI-compatible public refs (chatcmpl-*, resp_*) plus actor-scoped internal ProductWorkflow/projection ref mappings.
  • Added OpenAiCompatRefStore with in-memory and filesystem-backed durable adapters for idempotency replay/conflict, bind, lookup, stream-resume, and cancel authorization semantics.
  • Added fail-closed validation for malformed refs, inconsistent public-id/surface mappings, corrupt persisted state, cross-actor lookup/bind non-leakage, and sanitized ref-store errors.
  • Documented the OpenAI-compatible ref/idempotency contract and storage placement under /engine/openai_compat/refs/state.json.

Change Type

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • CI/Infrastructure
  • Security
  • Dependencies

Linked Issue

Closes #4443

Depends on #4442

Part of #3283

Validation

  • cargo fmt --all -- --check
  • cargo clippy --all --benches --tests --examples --all-features -- -D warnings
  • cargo build
  • Relevant tests pass: cargo test -p ironclaw_reborn_openai_compat --features openai-compat-beta, cargo test -p ironclaw_reborn_openai_compat --test refs_contract, cargo test -p ironclaw_reborn_openai_compat_storage, cargo test -p ironclaw_architecture reborn_crate_dependency_boundaries_hold, cargo test -p ironclaw_architecture reborn_boundary_rules_active_crates_are_workspace_members
  • cargo test --features integration if database-backed or integration behavior changed
  • Manual testing: Not applicable; this is a contract/storage slice with no route behavior wired yet.
  • If a coding agent was used and supports it, review-pr or pr-shepherd --fix was run before requesting review

Additional validation:

  • cargo clippy -p ironclaw_reborn_openai_compat --all-targets --all-features -- -D warnings
  • cargo clippy -p ironclaw_reborn_openai_compat_storage --all-targets --all-features -- -D warnings
  • git diff --check

Security Impact

Yes. This adds the OpenAI-compatible opaque ref/idempotency boundary used before route behavior is wired. Public refs do not encode tenant, user, thread, run, cursor, projection, or host paths. Ref lookup, stream resume, bind, and cancel semantics are actor/scope checked, and unauthorized refs are indistinguishable from nonexistent refs. Persisted mappings fail closed if corrupt or if the public id kind does not match the declared route surface.

Database Impact

No schema or migration changes. The durable adapter stores a CAS-protected JSON state record through RootFilesystem at /engine/openai_compat/refs/state.json; PostgreSQL/libSQL parity comes from the selected filesystem backend.

Blast Radius

Limited to the new Reborn OpenAI-compatible contract/storage crates, route DTO id typing, architecture boundary docs/tests, and Reborn storage-placement documentation. Existing v1 gateway behavior and concrete Reborn route handling are unchanged.

Rollback Plan

Revert this PR to remove the OpenAI-compatible ref/idempotency store and return the OpenAI-compatible contract surface to DTO/descriptors-only behavior from #4442.

Review Follow-Through

Reviewer judgment requested on whether the initial filesystem-backed single-state record is sufficient for the first route rollout slice, or whether indexed durable rows should be pulled forward before high-volume route behavior is wired.


Review track: C

@github-actions github-actions Bot added scope: docs Documentation scope: dependencies Dependency updates size: XL 500+ changed lines risk: medium Business logic, config, or moderate-risk modules contributor: core 20+ merged PRs labels Jun 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ironclaw_reborn_openai_compat_storage crate and updates ironclaw_reborn_openai_compat to implement durable, filesystem-backed storage adapters for OpenAI-compatible public references and idempotency mappings. The changes establish the OpenAiCompatRefStore port and its implementations, along with boundary rules, documentation, and tests. Feedback from the review suggests replacing a hand-rolled hex encoding implementation with the standard hex crate and adding documentation to clarify that string length limits are validated in bytes to avoid character-counting overhead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread crates/ironclaw_reborn_openai_compat/Cargo.toml
Comment thread crates/ironclaw_reborn_openai_compat/src/refs.rs Outdated
Comment thread crates/ironclaw_reborn_openai_compat/src/refs.rs Outdated
Comment thread crates/ironclaw_reborn_openai_compat/src/refs.rs

@abbyshekit abbyshekit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review — feat(reborn): add OpenAI-compatible product refs

Multi-agent review (security · bugs · performance · tests · conventions) at 03be9aa4. Diff-only mode.

Independent review of an open PR.

2 findings — 1 High, 1 Medium. Posted as a comment (advisory). Confidence ≥ 50, deduplicated across reviewers.

Sev Conf Reviewer Location Finding
High 85% performance lib.rs:225 All actors' ref mappings serialize through one global state.json CAS record — O(N)/op + write contention that fails under concurrency
Medium 65% conventions refs.rs:54 Newly-added validated newtypes use #[serde(transparent)], the pattern types.md explicitly flags

Generated by near-ai-code-review (5 parallel reviewer agents + intent analysis). Diff-only; confidence ≥ 50; ≤ 15 inline comments.

Comment thread crates/ironclaw_reborn_openai_compat_storage/src/lib.rs
Comment thread crates/ironclaw_reborn_openai_compat/src/refs.rs
@hanakannzashi
hanakannzashi force-pushed the issue-4443-reborn-openai-product-refs branch from b3cc727 to f02dab6 Compare June 8, 2026 06:35

@think-in-universe think-in-universe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review pass for the #3283 OpenAI-compatible refs slice. I found two remaining fail-closed validation gaps in the durable storage path.

Comment thread crates/ironclaw_reborn_openai_compat_storage/src/lib.rs
Comment thread crates/ironclaw_reborn_openai_compat_storage/src/lib.rs
@serrrfirat
serrrfirat merged commit 68730db into issue-4442-reborn-openai-api-contracts Jun 8, 2026
15 checks passed
@serrrfirat
serrrfirat deleted the issue-4443-reborn-openai-product-refs branch June 8, 2026 10:23
serrrfirat pushed a commit that referenced this pull request Jun 8, 2026
* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* test(reborn): stabilize subagent cancellation propagation

* feat(reborn): add OpenAI-compatible product refs (#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>
serrrfirat pushed a commit that referenced this pull request Jun 9, 2026
* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* feat(reborn): route chat completions through ProductWorkflow

* fix(reborn): simplify chat completion timestamps

* fix(reborn): use explicit ProductWorkflow submit door

* test(reborn): stabilize subagent cancellation propagation

* Validate durable OpenAI compat ref records

* Fix chat completions idempotency validation

* Format OpenAI compat storage review fixes

* feat(reborn): add OpenAI-compatible product refs (#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

* Address chat completions review comments

* Persist chat completion idempotency replay metadata

* Export OpenAI compat ack recording request

* Persist OpenAI compat accepted workflow acks

* fix(reborn): resolve chat completions review feedback

* fix(reborn): resolve chat completions review feedback

* fix(openai-compat): address chat workflow review comments

* fix(openai-compat): address chat ref store review

* fix(reborn): resolve chat projections through workflow

* feat(reborn): wire OpenAI chat completions route

* fix(reborn): centralize chat body validation

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>
Co-authored-by: Robert Yan <46699230+think-in-universe@users.noreply.github.com>
think-in-universe added a commit that referenced this pull request Jun 9, 2026
* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* feat(reborn): route chat completions through ProductWorkflow

* fix(reborn): simplify chat completion timestamps

* fix(reborn): use explicit ProductWorkflow submit door

* test(reborn): stabilize subagent cancellation propagation

* Validate durable OpenAI compat ref records

* Fix chat completions idempotency validation

* Format OpenAI compat storage review fixes

* feat(reborn): add OpenAI-compatible product refs (#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

* Address chat completions review comments

* Persist chat completion idempotency replay metadata

* Export OpenAI compat ack recording request

* Persist OpenAI compat accepted workflow acks

* feat(reborn): route responses through ProductWorkflow

* fix(reborn): declare compat storage chrono dependency

* fix(reborn): resolve chat completions review feedback

* fix(reborn): resolve chat completions review feedback

* fix(reborn): keep responses cancel within adapter boundary

* fix(openai-compat): address chat workflow review comments

* fix(openai-compat): address responses handler review comments

* fix(openai-compat): persist responses replay state

* test(openai-compat): cover responses review paths

* fix(openai-compat): annotate optional responses router state

* test(product-adapters): cover cancel run payload validation

* fix(openai-compat): address chat ref store review

* fix(reborn): resolve chat projections through workflow

* fix(reborn): close responses workflow review gaps

* test(reborn): cover responses wait cancellation

* feat(reborn): wire OpenAI chat completions route

* fix(reborn): wire OpenAI responses composition

* fix(reborn): centralize chat body validation

* fix(reborn): centralize responses body validation

* fix(reborn): keep OpenAI compat off turns

---------

Co-authored-by: Coffee <zjchen1234@foxmail.com>
think-in-universe added a commit that referenced this pull request Jun 9, 2026
* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* feat(reborn): route chat completions through ProductWorkflow

* fix(reborn): simplify chat completion timestamps

* fix(reborn): use explicit ProductWorkflow submit door

* test(reborn): stabilize subagent cancellation propagation

* Validate durable OpenAI compat ref records

* Fix chat completions idempotency validation

* Format OpenAI compat storage review fixes

* feat(reborn): add OpenAI-compatible product refs (#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

* Address chat completions review comments

* Persist chat completion idempotency replay metadata

* Export OpenAI compat ack recording request

* Persist OpenAI compat accepted workflow acks

* feat(reborn): route responses through ProductWorkflow

* fix(reborn): declare compat storage chrono dependency

* fix(reborn): resolve chat completions review feedback

* fix(reborn): resolve chat completions review feedback

* fix(reborn): keep responses cancel within adapter boundary

* feat(reborn): translate projection streams to OpenAI SSE

* fix(reborn): format chat streaming workflow

* fix(reborn): format responses streaming workflow

* fix(reborn): handle terminal projection stream status

* fix(reborn): make OpenAI stream replay terminal-safe

* fix(openai-compat): address chat workflow review comments

* fix(openai-compat): address responses handler review comments

* fix(openai-compat): persist responses replay state

* test(openai-compat): cover responses review paths

* fix(openai-compat): annotate optional responses router state

* test(product-adapters): cover cancel run payload validation

* fix(openai-compat): address chat ref store review

* fix(reborn): resolve chat projections through workflow

* fix(reborn): close responses workflow review gaps

* test(reborn): cover responses wait cancellation

* fix(reborn): update streaming tests for projection reader

* fix(reborn): close OpenAI stream review gaps

* fix(reborn): tighten OpenAI workflow internals

* feat(reborn): wire OpenAI chat completions route

* fix(reborn): wire OpenAI responses composition

* fix(reborn): wire OpenAI projection streams

* fix(reborn): centralize chat body validation

* fix(reborn): centralize responses body validation

* fix(reborn): keep OpenAI compat off turns

---------

Co-authored-by: Coffee <zjchen1234@foxmail.com>
think-in-universe added a commit that referenced this pull request Jun 9, 2026
* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* feat(reborn): route chat completions through ProductWorkflow

* fix(reborn): simplify chat completion timestamps

* fix(reborn): use explicit ProductWorkflow submit door

* test(reborn): stabilize subagent cancellation propagation

* Validate durable OpenAI compat ref records

* Fix chat completions idempotency validation

* Format OpenAI compat storage review fixes

* feat(reborn): add OpenAI-compatible product refs (#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

* Address chat completions review comments

* Persist chat completion idempotency replay metadata

* Export OpenAI compat ack recording request

* Persist OpenAI compat accepted workflow acks

* feat(reborn): route responses through ProductWorkflow

* fix(reborn): declare compat storage chrono dependency

* fix(reborn): resolve chat completions review feedback

* fix(reborn): resolve chat completions review feedback

* fix(reborn): keep responses cancel within adapter boundary

* feat(reborn): translate projection streams to OpenAI SSE

* fix(reborn): format chat streaming workflow

* fix(reborn): format responses streaming workflow

* fix(reborn): handle terminal projection stream status

* fix(reborn): make OpenAI stream replay terminal-safe

* test(reborn): close OpenAI compat security gates

* fix(reborn): keep responses unsupported-tooling router reusable

* fix(openai-compat): address chat workflow review comments

* fix(openai-compat): address responses handler review comments

* fix(openai-compat): persist responses replay state

* test(openai-compat): cover responses review paths

* fix(openai-compat): annotate optional responses router state

* test(product-adapters): cover cancel run payload validation

* fix(openai-compat): address chat ref store review

* fix(reborn): resolve chat projections through workflow

* fix(reborn): close responses workflow review gaps

* test(reborn): cover responses wait cancellation

* fix(reborn): update streaming tests for projection reader

* fix(reborn): close OpenAI stream review gaps

* fix(reborn): tighten OpenAI workflow internals

* feat(reborn): wire OpenAI chat completions route

* fix(reborn): wire OpenAI responses composition

* fix(reborn): wire OpenAI projection streams

* fix(reborn): centralize chat body validation

* fix(reborn): centralize responses body validation

* fix(reborn): keep OpenAI compat off turns

---------

Co-authored-by: Coffee <zjchen1234@foxmail.com>
theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026
* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* test(reborn): stabilize subagent cancellation propagation

* feat(reborn): add OpenAI-compatible product refs (nearai#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>
theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026
…4495)

* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* feat(reborn): route chat completions through ProductWorkflow

* fix(reborn): simplify chat completion timestamps

* fix(reborn): use explicit ProductWorkflow submit door

* test(reborn): stabilize subagent cancellation propagation

* Validate durable OpenAI compat ref records

* Fix chat completions idempotency validation

* Format OpenAI compat storage review fixes

* feat(reborn): add OpenAI-compatible product refs (nearai#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

* Address chat completions review comments

* Persist chat completion idempotency replay metadata

* Export OpenAI compat ack recording request

* Persist OpenAI compat accepted workflow acks

* fix(reborn): resolve chat completions review feedback

* fix(reborn): resolve chat completions review feedback

* fix(openai-compat): address chat workflow review comments

* fix(openai-compat): address chat ref store review

* fix(reborn): resolve chat projections through workflow

* feat(reborn): wire OpenAI chat completions route

* fix(reborn): centralize chat body validation

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>
Co-authored-by: Robert Yan <46699230+think-in-universe@users.noreply.github.com>
theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026
* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* feat(reborn): route chat completions through ProductWorkflow

* fix(reborn): simplify chat completion timestamps

* fix(reborn): use explicit ProductWorkflow submit door

* test(reborn): stabilize subagent cancellation propagation

* Validate durable OpenAI compat ref records

* Fix chat completions idempotency validation

* Format OpenAI compat storage review fixes

* feat(reborn): add OpenAI-compatible product refs (nearai#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

* Address chat completions review comments

* Persist chat completion idempotency replay metadata

* Export OpenAI compat ack recording request

* Persist OpenAI compat accepted workflow acks

* feat(reborn): route responses through ProductWorkflow

* fix(reborn): declare compat storage chrono dependency

* fix(reborn): resolve chat completions review feedback

* fix(reborn): resolve chat completions review feedback

* fix(reborn): keep responses cancel within adapter boundary

* fix(openai-compat): address chat workflow review comments

* fix(openai-compat): address responses handler review comments

* fix(openai-compat): persist responses replay state

* test(openai-compat): cover responses review paths

* fix(openai-compat): annotate optional responses router state

* test(product-adapters): cover cancel run payload validation

* fix(openai-compat): address chat ref store review

* fix(reborn): resolve chat projections through workflow

* fix(reborn): close responses workflow review gaps

* test(reborn): cover responses wait cancellation

* feat(reborn): wire OpenAI chat completions route

* fix(reborn): wire OpenAI responses composition

* fix(reborn): centralize chat body validation

* fix(reborn): centralize responses body validation

* fix(reborn): keep OpenAI compat off turns

---------

Co-authored-by: Coffee <zjchen1234@foxmail.com>
theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026
* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* feat(reborn): route chat completions through ProductWorkflow

* fix(reborn): simplify chat completion timestamps

* fix(reborn): use explicit ProductWorkflow submit door

* test(reborn): stabilize subagent cancellation propagation

* Validate durable OpenAI compat ref records

* Fix chat completions idempotency validation

* Format OpenAI compat storage review fixes

* feat(reborn): add OpenAI-compatible product refs (nearai#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

* Address chat completions review comments

* Persist chat completion idempotency replay metadata

* Export OpenAI compat ack recording request

* Persist OpenAI compat accepted workflow acks

* feat(reborn): route responses through ProductWorkflow

* fix(reborn): declare compat storage chrono dependency

* fix(reborn): resolve chat completions review feedback

* fix(reborn): resolve chat completions review feedback

* fix(reborn): keep responses cancel within adapter boundary

* feat(reborn): translate projection streams to OpenAI SSE

* fix(reborn): format chat streaming workflow

* fix(reborn): format responses streaming workflow

* fix(reborn): handle terminal projection stream status

* fix(reborn): make OpenAI stream replay terminal-safe

* fix(openai-compat): address chat workflow review comments

* fix(openai-compat): address responses handler review comments

* fix(openai-compat): persist responses replay state

* test(openai-compat): cover responses review paths

* fix(openai-compat): annotate optional responses router state

* test(product-adapters): cover cancel run payload validation

* fix(openai-compat): address chat ref store review

* fix(reborn): resolve chat projections through workflow

* fix(reborn): close responses workflow review gaps

* test(reborn): cover responses wait cancellation

* fix(reborn): update streaming tests for projection reader

* fix(reborn): close OpenAI stream review gaps

* fix(reborn): tighten OpenAI workflow internals

* feat(reborn): wire OpenAI chat completions route

* fix(reborn): wire OpenAI responses composition

* fix(reborn): wire OpenAI projection streams

* fix(reborn): centralize chat body validation

* fix(reborn): centralize responses body validation

* fix(reborn): keep OpenAI compat off turns

---------

Co-authored-by: Coffee <zjchen1234@foxmail.com>
theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026
* feat(reborn): add OpenAI-compatible API contracts

* fix(reborn): tighten OpenAI-compatible response contracts

* fix(reborn): address OpenAI compat contract review

* fix(reborn): satisfy merged main clippy

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* feat(reborn): route chat completions through ProductWorkflow

* fix(reborn): simplify chat completion timestamps

* fix(reborn): use explicit ProductWorkflow submit door

* test(reborn): stabilize subagent cancellation propagation

* Validate durable OpenAI compat ref records

* Fix chat completions idempotency validation

* Format OpenAI compat storage review fixes

* feat(reborn): add OpenAI-compatible product refs (nearai#4489)

* feat(reborn): add OpenAI-compatible product refs

* fix(reborn): validate OpenAI-compatible ref mappings

* fix(reborn): address OpenAI product refs review

* Validate durable OpenAI compat ref records

* Format OpenAI compat storage review fixes

---------

Co-authored-by: Robert Yan <mstr.raphael@gmail.com>

* Address chat completions review comments

* Persist chat completion idempotency replay metadata

* Export OpenAI compat ack recording request

* Persist OpenAI compat accepted workflow acks

* feat(reborn): route responses through ProductWorkflow

* fix(reborn): declare compat storage chrono dependency

* fix(reborn): resolve chat completions review feedback

* fix(reborn): resolve chat completions review feedback

* fix(reborn): keep responses cancel within adapter boundary

* feat(reborn): translate projection streams to OpenAI SSE

* fix(reborn): format chat streaming workflow

* fix(reborn): format responses streaming workflow

* fix(reborn): handle terminal projection stream status

* fix(reborn): make OpenAI stream replay terminal-safe

* test(reborn): close OpenAI compat security gates

* fix(reborn): keep responses unsupported-tooling router reusable

* fix(openai-compat): address chat workflow review comments

* fix(openai-compat): address responses handler review comments

* fix(openai-compat): persist responses replay state

* test(openai-compat): cover responses review paths

* fix(openai-compat): annotate optional responses router state

* test(product-adapters): cover cancel run payload validation

* fix(openai-compat): address chat ref store review

* fix(reborn): resolve chat projections through workflow

* fix(reborn): close responses workflow review gaps

* test(reborn): cover responses wait cancellation

* fix(reborn): update streaming tests for projection reader

* fix(reborn): close OpenAI stream review gaps

* fix(reborn): tighten OpenAI workflow internals

* feat(reborn): wire OpenAI chat completions route

* fix(reborn): wire OpenAI responses composition

* fix(reborn): wire OpenAI projection streams

* fix(reborn): centralize chat body validation

* fix(reborn): centralize responses body validation

* fix(reborn): keep OpenAI compat off turns

---------

Co-authored-by: Coffee <zjchen1234@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: dependencies Dependency updates scope: docs Documentation size: XL 500+ changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants