Repository navigation
feat(reborn): add OpenAI-compatible product refs - #4489
serrrfirat merged 5 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the ironclaw_reborn_openai_compat_storage crate and updates ironclaw_reborn_openai_compat to implement durable, filesystem-backed storage adapters for OpenAI-compatible public references and idempotency mappings. The changes establish the OpenAiCompatRefStore port and its implementations, along with boundary rules, documentation, and tests. Feedback from the review suggests replacing a hand-rolled hex encoding implementation with the standard hex crate and adding documentation to clarify that string length limits are validated in bytes to avoid character-counting overhead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
abbyshekit
left a comment
There was a problem hiding this comment.
Code review — feat(reborn): add OpenAI-compatible product refs
Multi-agent review (security · bugs · performance · tests · conventions) at 03be9aa4. Diff-only mode.
Independent review of an open PR.
2 findings — 1 High, 1 Medium. Posted as a comment (advisory). Confidence ≥ 50, deduplicated across reviewers.
| Sev | Conf | Reviewer | Location | Finding |
|---|---|---|---|---|
| High | 85% | performance | lib.rs:225 |
All actors' ref mappings serialize through one global state.json CAS record — O(N)/op + write contention that fails under concurrency |
| Medium | 65% | conventions | refs.rs:54 |
Newly-added validated newtypes use #[serde(transparent)], the pattern types.md explicitly flags |
Generated by near-ai-code-review (5 parallel reviewer agents + intent analysis). Diff-only; confidence ≥ 50; ≤ 15 inline comments.
03be9aa to
587aa48
Compare
587aa48 to
b3cc727
Compare
b3cc727 to
f02dab6
Compare
think-in-universe
left a comment
There was a problem hiding this comment.
Review pass for the #3283 OpenAI-compatible refs slice. I found two remaining fail-closed validation gaps in the durable storage path.
68730db
into
issue-4442-reborn-openai-api-contracts
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * test(reborn): stabilize subagent cancellation propagation * feat(reborn): add OpenAI-compatible product refs (#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com>
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * feat(reborn): route chat completions through ProductWorkflow * fix(reborn): simplify chat completion timestamps * fix(reborn): use explicit ProductWorkflow submit door * test(reborn): stabilize subagent cancellation propagation * Validate durable OpenAI compat ref records * Fix chat completions idempotency validation * Format OpenAI compat storage review fixes * feat(reborn): add OpenAI-compatible product refs (#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> * Address chat completions review comments * Persist chat completion idempotency replay metadata * Export OpenAI compat ack recording request * Persist OpenAI compat accepted workflow acks * fix(reborn): resolve chat completions review feedback * fix(reborn): resolve chat completions review feedback * fix(openai-compat): address chat workflow review comments * fix(openai-compat): address chat ref store review * fix(reborn): resolve chat projections through workflow * feat(reborn): wire OpenAI chat completions route * fix(reborn): centralize chat body validation --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> Co-authored-by: Robert Yan <46699230+think-in-universe@users.noreply.github.com>
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * feat(reborn): route chat completions through ProductWorkflow * fix(reborn): simplify chat completion timestamps * fix(reborn): use explicit ProductWorkflow submit door * test(reborn): stabilize subagent cancellation propagation * Validate durable OpenAI compat ref records * Fix chat completions idempotency validation * Format OpenAI compat storage review fixes * feat(reborn): add OpenAI-compatible product refs (#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> * Address chat completions review comments * Persist chat completion idempotency replay metadata * Export OpenAI compat ack recording request * Persist OpenAI compat accepted workflow acks * feat(reborn): route responses through ProductWorkflow * fix(reborn): declare compat storage chrono dependency * fix(reborn): resolve chat completions review feedback * fix(reborn): resolve chat completions review feedback * fix(reborn): keep responses cancel within adapter boundary * fix(openai-compat): address chat workflow review comments * fix(openai-compat): address responses handler review comments * fix(openai-compat): persist responses replay state * test(openai-compat): cover responses review paths * fix(openai-compat): annotate optional responses router state * test(product-adapters): cover cancel run payload validation * fix(openai-compat): address chat ref store review * fix(reborn): resolve chat projections through workflow * fix(reborn): close responses workflow review gaps * test(reborn): cover responses wait cancellation * feat(reborn): wire OpenAI chat completions route * fix(reborn): wire OpenAI responses composition * fix(reborn): centralize chat body validation * fix(reborn): centralize responses body validation * fix(reborn): keep OpenAI compat off turns --------- Co-authored-by: Coffee <zjchen1234@foxmail.com>
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * feat(reborn): route chat completions through ProductWorkflow * fix(reborn): simplify chat completion timestamps * fix(reborn): use explicit ProductWorkflow submit door * test(reborn): stabilize subagent cancellation propagation * Validate durable OpenAI compat ref records * Fix chat completions idempotency validation * Format OpenAI compat storage review fixes * feat(reborn): add OpenAI-compatible product refs (#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> * Address chat completions review comments * Persist chat completion idempotency replay metadata * Export OpenAI compat ack recording request * Persist OpenAI compat accepted workflow acks * feat(reborn): route responses through ProductWorkflow * fix(reborn): declare compat storage chrono dependency * fix(reborn): resolve chat completions review feedback * fix(reborn): resolve chat completions review feedback * fix(reborn): keep responses cancel within adapter boundary * feat(reborn): translate projection streams to OpenAI SSE * fix(reborn): format chat streaming workflow * fix(reborn): format responses streaming workflow * fix(reborn): handle terminal projection stream status * fix(reborn): make OpenAI stream replay terminal-safe * fix(openai-compat): address chat workflow review comments * fix(openai-compat): address responses handler review comments * fix(openai-compat): persist responses replay state * test(openai-compat): cover responses review paths * fix(openai-compat): annotate optional responses router state * test(product-adapters): cover cancel run payload validation * fix(openai-compat): address chat ref store review * fix(reborn): resolve chat projections through workflow * fix(reborn): close responses workflow review gaps * test(reborn): cover responses wait cancellation * fix(reborn): update streaming tests for projection reader * fix(reborn): close OpenAI stream review gaps * fix(reborn): tighten OpenAI workflow internals * feat(reborn): wire OpenAI chat completions route * fix(reborn): wire OpenAI responses composition * fix(reborn): wire OpenAI projection streams * fix(reborn): centralize chat body validation * fix(reborn): centralize responses body validation * fix(reborn): keep OpenAI compat off turns --------- Co-authored-by: Coffee <zjchen1234@foxmail.com>
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * feat(reborn): route chat completions through ProductWorkflow * fix(reborn): simplify chat completion timestamps * fix(reborn): use explicit ProductWorkflow submit door * test(reborn): stabilize subagent cancellation propagation * Validate durable OpenAI compat ref records * Fix chat completions idempotency validation * Format OpenAI compat storage review fixes * feat(reborn): add OpenAI-compatible product refs (#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> * Address chat completions review comments * Persist chat completion idempotency replay metadata * Export OpenAI compat ack recording request * Persist OpenAI compat accepted workflow acks * feat(reborn): route responses through ProductWorkflow * fix(reborn): declare compat storage chrono dependency * fix(reborn): resolve chat completions review feedback * fix(reborn): resolve chat completions review feedback * fix(reborn): keep responses cancel within adapter boundary * feat(reborn): translate projection streams to OpenAI SSE * fix(reborn): format chat streaming workflow * fix(reborn): format responses streaming workflow * fix(reborn): handle terminal projection stream status * fix(reborn): make OpenAI stream replay terminal-safe * test(reborn): close OpenAI compat security gates * fix(reborn): keep responses unsupported-tooling router reusable * fix(openai-compat): address chat workflow review comments * fix(openai-compat): address responses handler review comments * fix(openai-compat): persist responses replay state * test(openai-compat): cover responses review paths * fix(openai-compat): annotate optional responses router state * test(product-adapters): cover cancel run payload validation * fix(openai-compat): address chat ref store review * fix(reborn): resolve chat projections through workflow * fix(reborn): close responses workflow review gaps * test(reborn): cover responses wait cancellation * fix(reborn): update streaming tests for projection reader * fix(reborn): close OpenAI stream review gaps * fix(reborn): tighten OpenAI workflow internals * feat(reborn): wire OpenAI chat completions route * fix(reborn): wire OpenAI responses composition * fix(reborn): wire OpenAI projection streams * fix(reborn): centralize chat body validation * fix(reborn): centralize responses body validation * fix(reborn): keep OpenAI compat off turns --------- Co-authored-by: Coffee <zjchen1234@foxmail.com>
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * test(reborn): stabilize subagent cancellation propagation * feat(reborn): add OpenAI-compatible product refs (nearai#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com>
…4495) * feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * feat(reborn): route chat completions through ProductWorkflow * fix(reborn): simplify chat completion timestamps * fix(reborn): use explicit ProductWorkflow submit door * test(reborn): stabilize subagent cancellation propagation * Validate durable OpenAI compat ref records * Fix chat completions idempotency validation * Format OpenAI compat storage review fixes * feat(reborn): add OpenAI-compatible product refs (nearai#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> * Address chat completions review comments * Persist chat completion idempotency replay metadata * Export OpenAI compat ack recording request * Persist OpenAI compat accepted workflow acks * fix(reborn): resolve chat completions review feedback * fix(reborn): resolve chat completions review feedback * fix(openai-compat): address chat workflow review comments * fix(openai-compat): address chat ref store review * fix(reborn): resolve chat projections through workflow * feat(reborn): wire OpenAI chat completions route * fix(reborn): centralize chat body validation --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> Co-authored-by: Robert Yan <46699230+think-in-universe@users.noreply.github.com>
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * feat(reborn): route chat completions through ProductWorkflow * fix(reborn): simplify chat completion timestamps * fix(reborn): use explicit ProductWorkflow submit door * test(reborn): stabilize subagent cancellation propagation * Validate durable OpenAI compat ref records * Fix chat completions idempotency validation * Format OpenAI compat storage review fixes * feat(reborn): add OpenAI-compatible product refs (nearai#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> * Address chat completions review comments * Persist chat completion idempotency replay metadata * Export OpenAI compat ack recording request * Persist OpenAI compat accepted workflow acks * feat(reborn): route responses through ProductWorkflow * fix(reborn): declare compat storage chrono dependency * fix(reborn): resolve chat completions review feedback * fix(reborn): resolve chat completions review feedback * fix(reborn): keep responses cancel within adapter boundary * fix(openai-compat): address chat workflow review comments * fix(openai-compat): address responses handler review comments * fix(openai-compat): persist responses replay state * test(openai-compat): cover responses review paths * fix(openai-compat): annotate optional responses router state * test(product-adapters): cover cancel run payload validation * fix(openai-compat): address chat ref store review * fix(reborn): resolve chat projections through workflow * fix(reborn): close responses workflow review gaps * test(reborn): cover responses wait cancellation * feat(reborn): wire OpenAI chat completions route * fix(reborn): wire OpenAI responses composition * fix(reborn): centralize chat body validation * fix(reborn): centralize responses body validation * fix(reborn): keep OpenAI compat off turns --------- Co-authored-by: Coffee <zjchen1234@foxmail.com>
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * feat(reborn): route chat completions through ProductWorkflow * fix(reborn): simplify chat completion timestamps * fix(reborn): use explicit ProductWorkflow submit door * test(reborn): stabilize subagent cancellation propagation * Validate durable OpenAI compat ref records * Fix chat completions idempotency validation * Format OpenAI compat storage review fixes * feat(reborn): add OpenAI-compatible product refs (nearai#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> * Address chat completions review comments * Persist chat completion idempotency replay metadata * Export OpenAI compat ack recording request * Persist OpenAI compat accepted workflow acks * feat(reborn): route responses through ProductWorkflow * fix(reborn): declare compat storage chrono dependency * fix(reborn): resolve chat completions review feedback * fix(reborn): resolve chat completions review feedback * fix(reborn): keep responses cancel within adapter boundary * feat(reborn): translate projection streams to OpenAI SSE * fix(reborn): format chat streaming workflow * fix(reborn): format responses streaming workflow * fix(reborn): handle terminal projection stream status * fix(reborn): make OpenAI stream replay terminal-safe * fix(openai-compat): address chat workflow review comments * fix(openai-compat): address responses handler review comments * fix(openai-compat): persist responses replay state * test(openai-compat): cover responses review paths * fix(openai-compat): annotate optional responses router state * test(product-adapters): cover cancel run payload validation * fix(openai-compat): address chat ref store review * fix(reborn): resolve chat projections through workflow * fix(reborn): close responses workflow review gaps * test(reborn): cover responses wait cancellation * fix(reborn): update streaming tests for projection reader * fix(reborn): close OpenAI stream review gaps * fix(reborn): tighten OpenAI workflow internals * feat(reborn): wire OpenAI chat completions route * fix(reborn): wire OpenAI responses composition * fix(reborn): wire OpenAI projection streams * fix(reborn): centralize chat body validation * fix(reborn): centralize responses body validation * fix(reborn): keep OpenAI compat off turns --------- Co-authored-by: Coffee <zjchen1234@foxmail.com>
* feat(reborn): add OpenAI-compatible API contracts * fix(reborn): tighten OpenAI-compatible response contracts * fix(reborn): address OpenAI compat contract review * fix(reborn): satisfy merged main clippy * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * feat(reborn): route chat completions through ProductWorkflow * fix(reborn): simplify chat completion timestamps * fix(reborn): use explicit ProductWorkflow submit door * test(reborn): stabilize subagent cancellation propagation * Validate durable OpenAI compat ref records * Fix chat completions idempotency validation * Format OpenAI compat storage review fixes * feat(reborn): add OpenAI-compatible product refs (nearai#4489) * feat(reborn): add OpenAI-compatible product refs * fix(reborn): validate OpenAI-compatible ref mappings * fix(reborn): address OpenAI product refs review * Validate durable OpenAI compat ref records * Format OpenAI compat storage review fixes --------- Co-authored-by: Robert Yan <mstr.raphael@gmail.com> * Address chat completions review comments * Persist chat completion idempotency replay metadata * Export OpenAI compat ack recording request * Persist OpenAI compat accepted workflow acks * feat(reborn): route responses through ProductWorkflow * fix(reborn): declare compat storage chrono dependency * fix(reborn): resolve chat completions review feedback * fix(reborn): resolve chat completions review feedback * fix(reborn): keep responses cancel within adapter boundary * feat(reborn): translate projection streams to OpenAI SSE * fix(reborn): format chat streaming workflow * fix(reborn): format responses streaming workflow * fix(reborn): handle terminal projection stream status * fix(reborn): make OpenAI stream replay terminal-safe * test(reborn): close OpenAI compat security gates * fix(reborn): keep responses unsupported-tooling router reusable * fix(openai-compat): address chat workflow review comments * fix(openai-compat): address responses handler review comments * fix(openai-compat): persist responses replay state * test(openai-compat): cover responses review paths * fix(openai-compat): annotate optional responses router state * test(product-adapters): cover cancel run payload validation * fix(openai-compat): address chat ref store review * fix(reborn): resolve chat projections through workflow * fix(reborn): close responses workflow review gaps * test(reborn): cover responses wait cancellation * fix(reborn): update streaming tests for projection reader * fix(reborn): close OpenAI stream review gaps * fix(reborn): tighten OpenAI workflow internals * feat(reborn): wire OpenAI chat completions route * fix(reborn): wire OpenAI responses composition * fix(reborn): wire OpenAI projection streams * fix(reborn): centralize chat body validation * fix(reborn): centralize responses body validation * fix(reborn): keep OpenAI compat off turns --------- Co-authored-by: Coffee <zjchen1234@foxmail.com>
Summary
chatcmpl-*,resp_*) plus actor-scoped internal ProductWorkflow/projection ref mappings.OpenAiCompatRefStorewith in-memory and filesystem-backed durable adapters for idempotency replay/conflict, bind, lookup, stream-resume, and cancel authorization semantics./engine/openai_compat/refs/state.json.Change Type
Linked Issue
Closes #4443
Depends on #4442
Part of #3283
Validation
cargo fmt --all -- --checkcargo clippy --all --benches --tests --examples --all-features -- -D warningscargo buildcargo test -p ironclaw_reborn_openai_compat --features openai-compat-beta,cargo test -p ironclaw_reborn_openai_compat --test refs_contract,cargo test -p ironclaw_reborn_openai_compat_storage,cargo test -p ironclaw_architecture reborn_crate_dependency_boundaries_hold,cargo test -p ironclaw_architecture reborn_boundary_rules_active_crates_are_workspace_memberscargo test --features integrationif database-backed or integration behavior changedreview-prorpr-shepherd --fixwas run before requesting reviewAdditional validation:
cargo clippy -p ironclaw_reborn_openai_compat --all-targets --all-features -- -D warningscargo clippy -p ironclaw_reborn_openai_compat_storage --all-targets --all-features -- -D warningsgit diff --checkSecurity Impact
Yes. This adds the OpenAI-compatible opaque ref/idempotency boundary used before route behavior is wired. Public refs do not encode tenant, user, thread, run, cursor, projection, or host paths. Ref lookup, stream resume, bind, and cancel semantics are actor/scope checked, and unauthorized refs are indistinguishable from nonexistent refs. Persisted mappings fail closed if corrupt or if the public id kind does not match the declared route surface.
Database Impact
No schema or migration changes. The durable adapter stores a CAS-protected JSON state record through
RootFilesystemat/engine/openai_compat/refs/state.json; PostgreSQL/libSQL parity comes from the selected filesystem backend.Blast Radius
Limited to the new Reborn OpenAI-compatible contract/storage crates, route DTO id typing, architecture boundary docs/tests, and Reborn storage-placement documentation. Existing v1 gateway behavior and concrete Reborn route handling are unchanged.
Rollback Plan
Revert this PR to remove the OpenAI-compatible ref/idempotency store and return the OpenAI-compatible contract surface to DTO/descriptors-only behavior from #4442.
Review Follow-Through
Reviewer judgment requested on whether the initial filesystem-backed single-state record is sufficient for the first route rollout slice, or whether indexed durable rows should be pulled forward before high-volume route behavior is wired.
Review track: C