Skip to content

test(reborn): cover WASM runtime failure edges - #3117

Merged
serrrfirat merged 1 commit into
reborn-integrationfrom
reborn-wasm-runtime-coverage-tests
Apr 30, 2026
Merged

serrrfirat merged 1 commit into
reborn-integrationfrom
reborn-wasm-runtime-coverage-tests

Conversation

@serrrfirat

Copy link
Copy Markdown
Collaborator

Summary

Test-only follow-up for #3086 to close the remaining explicit WASM runtime coverage gaps after #3097 and #3109 landed.

Adds coverage for:

  • malformed non-WASM bytes rejected by WitToolRuntime::prepare
  • valid core WASM module bytes rejected because they are not component-model tools
  • component-model inputs without the required WIT tool exports
  • invalid WIT schema exports that are not JSON objects
  • missing WASM module files through the RuntimeDispatcher / RuntimeAdapter seam
  • malformed module bytes through the dispatch seam as sanitized manifest errors
  • invalid output JSON through the dispatch seam as sanitized output decode errors

No production code changes.

Verification

cargo fmt --all -- --check
CARGO_TARGET_DIR=/tmp/ironclaw-reborn-wasm-coverage-target cargo test -p ironclaw_wasm
CARGO_TARGET_DIR=/tmp/ironclaw-reborn-wasm-coverage-target cargo clippy -q -p ironclaw_wasm --all-targets -- -D warnings
CARGO_TARGET_DIR=/tmp/ironclaw-reborn-wasm-coverage-target cargo test -p ironclaw_architecture
CARGO_TARGET_DIR=/tmp/ironclaw-reborn-wasm-coverage-target cargo test -p ironclaw_dispatcher
git diff --check

Links

Completes #3086.
Part of #2987.

@serrrfirat serrrfirat added the reborn IronClaw Reborn architecture and landing work label Apr 30, 2026
@github-actions github-actions Bot added size: XS < 10 changed lines (excluding docs) risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Apr 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several integration and unit tests to verify error handling and sanitization for WASM module dispatching and runtime preparation. Specifically, it covers scenarios such as missing module files, malformed modules, invalid output JSON, and unsupported component exports. I have no feedback to provide.

@serrrfirat
serrrfirat merged commit 6aa1a26 into reborn-integration Apr 30, 2026
18 checks passed
@serrrfirat
serrrfirat deleted the reborn-wasm-runtime-coverage-tests branch April 30, 2026 14:02
theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs reborn IronClaw Reborn architecture and landing work risk: low Changes to docs, tests, or low-risk modules size: XS < 10 changed lines (excluding docs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant