test(reborn): add runtime lane dispatch smoke coverage by serrrfirat · Pull Request #3109 · nearai/ironclaw

serrrfirat · 2026-04-30T11:05:43Z

Summary

Implements issue #3067 Phase 2 runtime-lane smoke coverage now that Script/MCP (#3027) and WIT WASM (#3097) are both on reborn-integration.

Adds caller-level tests that drive each real runtime lane through the public RuntimeDispatcher / RuntimeAdapter seam instead of only through crate-local runtime contracts:

Script lane dispatch smoke in crates/ironclaw_scripts/tests/script_dispatch_integration.rs
- manifest command/args are used
- invocation input is passed as JSON stdin
- success reconciles resources
- non-zero exit and invalid JSON release reservations and emit sanitized dispatch failures
MCP lane dispatch smoke in crates/ironclaw_mcp/tests/mcp_dispatch_integration.rs
- manifest transport/command/args are used
- invocation input reaches the client adapter
- success reconciles resources
- client failure and output-limit failure release reservations and emit sanitized dispatch failures
WASM lane dispatch smoke in crates/ironclaw_wasm/tests/wasm_dispatch_integration.rs
- component bytes are loaded through RootFilesystem virtual paths
- canonical WIT/component-model exports are exercised
- fresh instance per dispatch is proven
- guest trap releases the reservation and emits sanitized dispatch failure

Also updates stale dispatcher test fixtures from obsolete trust = "sandbox" to trust = "untrusted", matching the current manifest parser.

Verification

cargo fmt --all -- --check
CARGO_TARGET_DIR=/tmp/ironclaw-reborn-integration-target cargo test -p ironclaw_dispatcher -p ironclaw_scripts -p ironclaw_mcp -p ironclaw_wasm
CARGO_TARGET_DIR=/tmp/ironclaw-reborn-integration-target cargo clippy -q -p ironclaw_dispatcher -p ironclaw_scripts -p ironclaw_mcp -p ironclaw_wasm --all-targets -- -D warnings
CARGO_TARGET_DIR=/tmp/ironclaw-reborn-integration-target cargo test -p ironclaw_architecture
python3.11 scripts/check_no_panics.py --base origin/reborn-integration --head HEAD
bash scripts/pre-commit-safety.sh
git diff --check

Links

Tracks [TEST] Reborn: Add vertical-slice integration test suite #3067 Phase 2
Related tracker: [EPIC] Track Reborn architecture landing strategy and grouped PR plan #2987

gemini-code-assist

Code Review

This pull request introduces comprehensive integration tests for the MCP, Script, and WASM dispatch lanes, while updating test fixtures to use the 'untrusted' trust level. Feedback identifies a trust level inconsistency in a manifest, a potential resource exhaustion vulnerability where expensive WASM compilation occurs before resource reservation, and resource leaks in test helpers due to the use of .keep() on temporary directories.

gemini-code-assist · 2026-04-30T11:09:14Z

+name = "GitHub MCP"
+version = "0.1.0"
+description = "GitHub MCP adapter"
+trust = "third_party"


The trust value "third_party" is inconsistent with the other test fixtures updated in this PR, which now use "untrusted". According to the PR description, fixtures are being updated to match the current manifest parser.

Suggested change

trust = "third_party"

trust = "untrusted"

gemini-code-assist · 2026-04-30T11:09:14Z

+        let prepared = self
+            .runtime
+            .prepare(request.capability_id.as_str(), &wasm_bytes)
+            .map_err(|error| DispatchError::Wasm {
+                kind: wasm_error_kind(&error),
+            })?;


Expensive WASM preparation (compilation) is performed before checking or creating a resource reservation. This is inconsistent with the MCP and Script lanes, and could allow a burst of requests to exhaust host CPU/memory during the compilation phase before the governor can apply concurrency limits. Consider moving the reservation logic to the beginning of dispatch_json.

References

Prioritize addressing contention and resource exhaustion issues, as these are considered high-priority correctness concerns.

gemini-code-assist · 2026-04-30T11:09:14Z

+}
+
+fn mounted_empty_extension_root() -> LocalFilesystem {
+    let storage = tempfile::tempdir().unwrap().keep();


Using .keep() on a TempDir prevents the directory from being deleted when the test finishes, leading to resource leaks in the /tmp directory. Consider returning the TempDir from this helper and binding it in the test function to manage its lifetime without leaking.

References

Encapsulate complex logic within helper functions and expose a simpler interface or data structure tailored to the caller's needs, such as returning resource handles to the caller for lifetime management.

gemini-code-assist · 2026-04-30T11:09:14Z

+}
+
+fn mounted_empty_extension_root() -> LocalFilesystem {
+    let storage = tempfile::tempdir().unwrap().keep();


Using .keep() on a TempDir prevents the directory from being deleted when the test finishes, leading to resource leaks in the /tmp directory. Consider returning the TempDir from this helper and binding it in the test function to manage its lifetime without leaking.

References

Encapsulate complex logic within helper functions and expose a simpler interface or data structure tailored to the caller's needs, such as returning resource handles to the caller for lifetime management.

gemini-code-assist · 2026-04-30T11:09:14Z

+}
+
+fn mounted_empty_extension_root() -> LocalFilesystem {
+    let storage = tempfile::tempdir().unwrap().keep();


Using .keep() on a TempDir prevents the directory from being deleted when the test finishes, leading to resource leaks in the /tmp directory. Consider returning the TempDir from this helper and binding it in the test function to manage its lifetime without leaking.

References

Encapsulate complex logic within helper functions and expose a simpler interface or data structure tailored to the caller's needs, such as returning resource handles to the caller for lifetime management.

* test(reborn): add runtime lane dispatch smoke coverage * test(reborn): harden runtime lane smoke coverage

test(reborn): add runtime lane dispatch smoke coverage

1a64f94

github-actions Bot added scope: dependencies Dependency updates size: S 10-49 changed lines risk: low Changes to docs, tests, or low-risk modules labels Apr 30, 2026

serrrfirat mentioned this pull request Apr 30, 2026

[TEST] Reborn: Add vertical-slice integration test suite #3067

Closed

52 of 66 tasks

github-actions Bot added the contributor: core 20+ merged PRs label Apr 30, 2026

gemini-code-assist Bot reviewed Apr 30, 2026

View reviewed changes

test(reborn): harden runtime lane smoke coverage

14de76e

serrrfirat merged commit 9314f85 into reborn-integration Apr 30, 2026
17 checks passed

serrrfirat deleted the reborn-integration-tests-phase2-runtime-lanes branch April 30, 2026 11:40

This was referenced Apr 30, 2026

[EPIC] Track Reborn architecture landing strategy and grouped PR plan #2987

Closed

test(reborn): cover WASM runtime failure edges #3117

Merged

[Reborn] Re-carve WASM runtime lane #3086

Closed

serrrfirat mentioned this pull request May 8, 2026

fix(secrets): harden durable credential stores #3412

Merged

8 of 14 tasks

theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026

test(reborn): add runtime lane dispatch smoke coverage (nearai#3109)

422930f

* test(reborn): add runtime lane dispatch smoke coverage * test(reborn): harden runtime lane smoke coverage

Navigation Menu

Repository navigation

test(reborn): add runtime lane dispatch smoke coverage - #3109

test(reborn): add runtime lane dispatch smoke coverage#3109
serrrfirat merged 2 commits into
reborn-integrationfrom
reborn-integration-tests-phase2-runtime-lanes

serrrfirat commented Apr 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

serrrfirat commented Apr 30, 2026

Summary

Verification

Links

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant