chore: promote staging to staging-promote/427783da-24468358894 (2026-04-15 22:13 UTC)

[ironclaw-ci]

Auto-promotion from staging CI

Batch range: a53eac5c2dec6b6cd5c08189086093fde64aa9cb..b3478cf3816a99d66313f1b89a0c3fa70219d7c3
Promotion branch: staging-promote/b3478cf3-24481112105
Base: staging-promote/427783da-24468358894
Triggered by: Staging CI batch at 2026-04-15 22:13 UTC

Commits in this batch (51):

• a7401ec fix(gateway): scope chat approvals to the active thread (fix(gateway): scope chat approvals to the active thread #2267)
• 4032f6d Fix paired Telegram owner scope routine visibility (Fix paired Telegram owner scope routine visibility #2258)
• 7d66d83 fix(engine): always append ActionResult for every tool call (fix(engine): always append ActionResult for every tool call #2322)
• 764e586 feat(engine): LLM council via per-call model override in CodeAct (feat(engine): LLM council via per-call model override in CodeAct #2320)
• 70862ed feat(config): default CLI_MODE to TUI instead of REPL (feat(config): default CLI_MODE to TUI #2329)
• 207c4d4 ci: build docker image in release process (ci: build docker image in release process #2321)
• cd9b60c fix: re-apply Telegram UTF-16 splitting and DB MIGRATION label (fix: re-apply Telegram UTF-16 splitting and DB MIGRATION label #2304)
• 88b87c0 feat: user-facing temperature setting (feat: user-facing temperature setting #2275)
• fdb0a13 chore: sync staging and main (chore: sync staging and main #2337)
• 3cb77fe fix: resolve cargo-deny failures (wildcard deps + rand advisory) (fix: resolve cargo-deny failures (wildcard deps + rand advisory) #2370)
• ed2d6dc fix web chat refresh active thread ([codex] Fix web chat refresh active thread #2330)
• 66ccafb chore(engine): update monty to v0.0.11 (chore(engine): update monty to v0.0.11 #2364)
• 4529f00 fix(engine): track consecutive action errors in orchestrator Tier 0 path (Orchestrator: add action error counting to Python execution loop #2325) (fix(engine): track consecutive action errors in orchestrator (#2325) #2340)
• 50fc280 fix(agent): detect and escalate repeated identical failing tool calls (Agent retries same failing tool call up to 50 times with no duplicate detection #2240) (fix(agent): detect and escalate repeated identical failing tool calls #2338)
• 3f6149c feat(cli): add ironclaw profile list subcommand (feat(cli): add ironclaw profile list subcommand #2288)
• 625cd85 Suppress LLM_BACKEND warning when config.toml and .env values match (Suppress LLM_BACKEND warning when config.toml and .env values match #2388)
• a9cea6c fix(ci): skip NearAI URL DNS validation for non-NearAI backends (fix(ci): skip NearAI URL DNS validation for non-NearAI backends #2080)
• 160a75e fix(llm): image detail field + /v1 base URL normalization (fix(llm): image detail field + /v1 base URL normalization #2380)
• 4dbb44c fix(docker): make runtime-staging the default Docker target for Railway (fix(docker): make runtime-staging the default Docker target for Railway #2244)
• 532fc61 feat: admin management panel — web UI for users and usage monitoring (feat: admin management panel — web UI for users and usage monitoring #1963)
• 16b7b06 feat(web): add ironclaw docs link (feat(web): add ironclaw docs link #2398)
• ba81044 fix(mcp): Install NEAR AI MCP server from environment config (fix(mcp): Install NEAR AI MCP server from environment config #2181)
• 57d7b54 Fix Feishu webhook auth refresh and extension card overflow (fix: Feishu webhook auth refresh and extension card overflow #2443)
• 7425dc0 fix(security): harden approval thread safety (TOCTOU + error handling) (fix(security): harden approval thread safety (TOCTOU + error handling) #2366)
• 86a9d0b fix: image generation with nearai models (fix: image generation with nearai models #1819)
• 46ff740 docs(setup): warn that Telegram open mode splits history (docs(setup): warn that Telegram open mode splits history #2427)
• aea2e87 fix(ux): actionable auth errors and improved CLI help for new users (should make it easy to use #1852) (fix(ux): actionable auth errors and improved CLI help for new users (#1852) #2315)
• ab1f279 fix: more strict check for registry to avoid false positives (fix: more strict check for registry to avoid false positives #2222)
• 019c048 refactor(llm): promote decorator chain settings from NearAiConfig to top-level LlmConfig (refactor(llm): promote decorator chain settings from NearAiConfig to top-level LlmConfig #1749)
• b6f5da8 perf(tunnel): reuse HTTP client in CustomTunnel health checks (perf(tunnel): reuse HTTP client in CustomTunnel health checks #1201)
• fe2b134 fix(engine): guard consecutive-error checks against None limit (fix(engine): guard consecutive-error checks against None limit #2460)
• 37669e6 fix(web): prevent browser crash from timer leaks, DOM growth, SSE buffer ([QA] Pages Unresponsive dialog and black screen crashes #2406) (fix(web): prevent browser crash from timer leaks, DOM growth, SSE buffer (#2406) #2441)
• 1041094 style: fix cargo fmt line wrapping in thread_ops.rs (style: fix cargo fmt in thread_ops.rs #2451)
• 0a9d816 fix(responses-api): thread creation, GET by ID, streaming delta, context injection (fix(responses-api): thread creation, GET by ID, streaming delta, context injection #2167)
• 1fa73a4 docs: add Responses API section to USER_MANAGEMENT_API (docs: add Responses API reference #2440)
• 5140279 docs: guide how to host ironclaw on google cloud (docs: add google tutorial #2262)
• d85c11d fix(telegram): route WASM owner_id fallback (fix(telegram): route WASM owner_id fallback #2349)
• 28c6a15 fix(ci): exclude test files from PR size classification (fix(ci): exclude test files from PR size classification #2387)
• d63601e fix(security): gate test URL rewriters behind #[cfg(test)] (fixes SECURITY: Remove env-var-controlled API URL rewriters from production WASM channel wrapper (Telegram & Slack) #2056) (fix(security): gate test URL rewriters behind #[cfg(test)] (fixes #2056) #2401)
• 82d341d fix(sandbox): try Docker socket before CLI binary check (fix(sandbox): try Docker socket before CLI binary check #2467)
• 2dc78b2 feat(db): add per-user CachedSettingsStore decorator (feat(db): add per-user CachedSettingsStore decorator #2425)
• 8973d1b fix: use gateway owner_id for relay OAuth nonce storage (fix: use gateway owner_id for relay OAuth nonce storage #2473)
• 16a0731 test(e2e): add Playwright persistence happy-path test (test(e2e): add Playwright persistence happy-path test #2475)
• ae1f698 fix(llm): map HTTP 413 to ContextLengthExceeded for auto-compaction (fix(llm): map HTTP 413 to ContextLengthExceeded for auto-compaction #2339)
• 4353493 fix(gateway): resolve assistant thread for threadless broadcasts (fix(gateway): resolve assistant thread for threadless broadcasts #2444)
• be0b33b fix: duplicate reasoning_content fields in chat completions response (fix: duplicate reasoning_content fields in chat completions response #2493)
• 62bb007 feat(tui): add multiline support and input clear (feat(tui): add multiline support and input clear #2449)
• 7206bf0 feat(gateway): rich tool cards in history + thread processing indicator (feat(gateway): rich tool cards in history + thread processing indicator #2477)
• 7008e9a feat(gate): persist "always approve" decisions to DB in v2 engine path (feat(gate): persist "always approve" decisions to DB in v2 engine path #2428)
• 427783d fix(engine): surface action errors to LLM with [ACTION FAILED] prefix (fix(engine): surface action errors to LLM with [ACTION FAILED] prefix #2326)
• ... and 1 more (see compare view)

Current commits in this promotion (0)

Current base: main
Current head: staging-promote/b3478cf3-24481112105
Current range: origin/main..origin/staging-promote/b3478cf3-24481112105

• (no non-merge commits in range)

Auto-updated by staging promotion metadata workflow

Waiting for gates:

• Tests: pending
• E2E: pending
• Claude Code review: pending (will post comments on this PR)

---

Auto-created by staging-ci workflow

[claude]

Code review

Found 7 issues:

1. [HIGH:85] Missing error handling for git rev-list command

   • Line 57: git rev-list -n1 "${EXPECTED_REF}" does not check exit code
   • If the tag doesn't exist in the repository, the command silently fails and EXPECTED_COMMIT becomes empty
   • No set -e to halt execution on errors
   • The comparison on line 59 would pass with unset variables, allowing invalid commits through

   ironclaw/.github/workflows/rebuild-release-image.yml

   Lines 57 to 60 in 7b65b92

   	EXPECTED_COMMIT=$(git rev-list -n1 "${EXPECTED_REF}")
   	ACTUAL_COMMIT=$(git rev-parse HEAD)
   	if [[ "${ACTUAL_COMMIT}" != "${EXPECTED_COMMIT}" ]]; then
   	echo "::error::Checked out commit '${ACTUAL_COMMIT}' does not match release tag '${EXPECTED_REF}' (${EXPECTED_COMMIT})"

2. [MEDIUM:85] Undocumented source_ref format requirement

   • Input description (lines 5-7) does not specify that source_ref must be a git tag in format ironclaw-vX.Y.Z
   • The check at line 45 enforces this but error messaging is confusing for users who provide just v1.2.3 or a branch name
   • Creates poor UX where validation fails but the expected format isn't clearly documented upfront

   ironclaw/.github/workflows/rebuild-release-image.yml

   Lines 5 to 12 in 7b65b92

   	inputs:
   	source_ref:
   	description: "Tag or branch to build from"
   	required: true
   	type: string
   	tag:
   	description: "Docker image tag to publish"
   	required: true

3. [MEDIUM:80] Missing explicit git operation error handling

   • Lines 57-58: Both git rev-list and git rev-parse commands lack error checking
   • If the repository state is corrupted or the tag is missing, the script continues with empty variables
   • Results in misleading error messages rather than clear failure diagnostics

   ironclaw/.github/workflows/rebuild-release-image.yml

   Lines 56 to 61 in 7b65b92

   	EXPECTED_COMMIT=$(git rev-list -n1 "${EXPECTED_REF}")
   	ACTUAL_COMMIT=$(git rev-parse HEAD)
   	if [[ "${ACTUAL_COMMIT}" != "${EXPECTED_COMMIT}" ]]; then
   	echo "::error::Checked out commit '${ACTUAL_COMMIT}' does not match release tag '${EXPECTED_REF}' (${EXPECTED_COMMIT})"
   	exit 1

4. [MEDIUM:70] Overly permissive workflow dispatch access

   • No approval mechanism required to trigger image rebuilds and Docker pushes
   • Any repository maintainer can invoke arbitrary rebuilds
   • While validation restricts to existing git refs, this is still a significant attack surface without additional approval gates

   ironclaw/.github/workflows/rebuild-release-image.yml

   Lines 2 to 13 in 7b65b92

   	on:
   	workflow_dispatch:
   	inputs:
   	source_ref:
   	description: "Tag or branch to build from"
   	required: true
   	type: string
   	tag:
   	description: "Docker image tag to publish"
   	required: true
   	type: string

5. [MEDIUM:70] Version extraction lacks robustness

   • Line 36: Sed regex uses greedy matching (`.*") which could backtrack excessively on malformed Cargo.toml
   • No validation that the extraction succeeded before using the result in comparisons
   • Should add explicit validation or use more precise regex

   ironclaw/.github/workflows/rebuild-release-image.yml

   Lines 36 to 38 in 7b65b92

   	VERSION=$(grep '^version' Cargo.toml | head -1 | sed 's/.*"\(.*\)"/\1/')
   	echo "version=${VERSION}" >> "$GITHUB_OUTPUT"
   	echo "Detected version: ${VERSION}"

6. [LOW:70] Unnecessary broad permissions

   • Line 23: actions: write permission is not used and should be removed
   • Workflow only needs contents: read (checkout) and packages: read (Docker operations)
   • Reduces attack surface by principle of least privilege

   ironclaw/.github/workflows/rebuild-release-image.yml

   Lines 21 to 25 in 7b65b92

   	runs-on: ubuntu-24.04
   	permissions:
   	actions: write
   	contents: read
   	packages: read

7. [LOW:60] Missing timeout on docker build-push

   • Line 78: docker/build-push-action has no explicit timeout specification
   • Falls back to 6-hour GitHub Actions default, leading to wasted CI time on hung jobs
   • Recommend adding a 30-minute timeout for faster failure feedback

   ironclaw/.github/workflows/rebuild-release-image.yml

   Lines 78 to 87 in 7b65b92

   	- name: Build and push
   	uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6
   	with:
   	context: .
   	push: true
   	tags: ${{ env.IMAGE_NAME }}:${{ inputs.tag }}
   	target: runtime
   	platforms: linux/amd64
   	cache-from: type=gha
   	cache-to: type=gha,mode=max