fix(ux): actionable auth errors and improved CLI help for new users (#1852) - #2315
Merged
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
github-actions
Bot
added
scope: agent
ilblackdragon
commented
Apr 11, 2026
ilblackdragon
left a comment
ilblackdragon
left a comment
Member
Author
There was a problem hiding this comment.
I did not find a blocking issue here.
This is mostly UX text, and the change is scoped. The provider-specific guidance in AuthFailed is useful. Minor note: because the error text is now policy-bearing product guidance, it is worth treating it as compatibility-sensitive and keeping snapshot-style coverage around the rendered messages for the important providers, not just the helper function.
ilblackdragon
added a commit
that referenced
this pull request
Apr 11, 2026
…vider Addresses PR #2315 review note: auth error text is now policy-bearing product guidance and warrants explicit coverage so future edits are deliberate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Addressed in 282e695: added snapshot-style assertions over the rendered AuthFailed messages for each important provider (nearai, openai, anthropic, ollama, openai_compatible, tinfoil, bedrock, plus the generic unknown-provider fallback). Tests use |
AuthFailed errors now include provider-specific guidance (which env var to set, relevant URLs, and how to run `ironclaw onboard --step provider`). CLI help text improved across top-level, onboard, models, config, and doctor commands to help new users discover the setup wizard and provider configuration commands. `models set-provider` now warns when an API key is missing after switching providers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…vider Addresses PR #2315 review note: auth error text is now policy-bearing product guidance and warrants explicit coverage so future edits are deliberate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ilblackdragon
force-pushed
the
fix/1852-ux-improvements
branch
from
April 13, 2026 04:02
282e695 to
5ed7902
Compare
This was referenced Apr 16, 2026
Merged
theredspoon
pushed a commit
to theredspoon/ironclaw
that referenced
this pull request
Jun 21, 2026
…earai#1852) (nearai#2315) * fix(ux): actionable error messages and improved CLI help for issue nearai#1852 AuthFailed errors now include provider-specific guidance (which env var to set, relevant URLs, and how to run `ironclaw onboard --step provider`). CLI help text improved across top-level, onboard, models, config, and doctor commands to help new users discover the setup wizard and provider configuration commands. `models set-provider` now warns when an API key is missing after switching providers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test(llm): snapshot coverage for rendered AuthFailed messages per provider Addresses PR nearai#2315 review note: auth error text is now policy-bearing product guidance and warrants explicit coverage so future edits are deliberate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(cli): use secrets-aware optional_env for API key check Addresses PR nearai#2315 review: API key warning now checks the secrets store overlay via optional_env() instead of raw std::env::var(), preventing false "API key required" warnings for users who stored keys via `ironclaw secrets`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #1852 with targeted UX improvements for non-technical users:
src/llm/error.rs:AuthFailednow includes provider-specific guidance with env var name, signup URL, andironclaw onboard --step providerhint. Covers all providers (4 new tests)src/cli/mod.rs: Top-level--helpnow has "Getting started" and "Common commands" sections;onboard/config/models/doctor/loginlong_about improvedsrc/cli/models.rs: Unknown provider errors list available providers; warns when API key env var not set after switching; model list footer shows how to switchTest plan
cargo fmt,cargo clippy --all-featureszero warnings🤖 Generated with Claude Code