Skip to content

fix: publish ironclaw_safety 0.2.0 - #1659

Merged
henrypark133 merged 1 commit into
mainfrom
codex/publish-ironclaw-safety
Mar 26, 2026
Merged

henrypark133 merged 1 commit into
mainfrom
codex/publish-ironclaw-safety

Conversation

@henrypark133

Copy link
Copy Markdown
Collaborator

Summary

  • bump ironclaw_safety from 0.1.0 to 0.2.0
  • remove publish = false so release-plz can publish ironclaw_safety
  • stop excluding ironclaw_safety from release-plz
  • update ironclaw to depend on ironclaw_safety 0.2.0

Why

After #1657, release-plz gets past ironclaw_common but still fails while verifying ironclaw because the packaged crate resolves ironclaw_safety from crates.io. The published 0.1.0 API does not match the current workspace API, so the release flow needs a new published ironclaw_safety version.

Verification

  • cargo test -p ironclaw_safety
  • cargo check -p ironclaw
  • cargo publish --dry-run --allow-dirty --manifest-path crates/ironclaw_safety/Cargo.toml

Copilot AI review requested due to automatic review settings March 26, 2026 01:16
@github-actions github-actions Bot added the scope: dependencies Dependency updates label Mar 26, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue preventing the successful release of the ironclaw crate by ensuring that ironclaw_safety is correctly versioned and publishable. The changes facilitate the release-plz workflow, resolving a dependency mismatch where the local workspace version of ironclaw_safety diverged from the version available on crates.io, which was causing verification failures during the release process.

Highlights

  • Version Bump: The ironclaw_safety crate has been updated from version 0.1.0 to 0.2.0 across the repository.
  • Publishing Enabled: The publish = false flag has been removed from crates/ironclaw_safety/Cargo.toml, allowing the crate to be published to crates.io.
  • Release-plz Configuration: The ironclaw_safety crate is no longer explicitly excluded from release-plz operations, enabling its proper release management.
  • Dependency Update: The main Cargo.toml has been updated to reflect the new 0.2.0 dependency for ironclaw_safety.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions github-actions Bot added size: S 10-49 changed lines risk: medium Business logic, config, or moderate-risk modules contributor: core 20+ merged PRs labels Mar 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables publishing of ironclaw_safety by bumping it to 0.2.0 and removing release-plz configuration that previously prevented publishing, so the ironclaw crate can resolve the correct ironclaw_safety API from crates.io during release.

Changes:

  • Bump ironclaw_safety crate version from 0.1.0 to 0.2.0 and make it publishable (remove publish = false).
  • Remove the release-plz package override that excluded ironclaw_safety from publishing.
  • Update ironclaw to depend on ironclaw_safety 0.2.0 and refresh Cargo.lock.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
release-plz.toml Removes the package-level block that prevented ironclaw_safety from being released/published by release-plz.
crates/ironclaw_safety/Cargo.toml Bumps crate version to 0.2.0 and removes publish = false so it can be published to crates.io.
Cargo.toml Updates the ironclaw crate’s dependency on ironclaw_safety to 0.2.0.
Cargo.lock Updates the locked ironclaw_safety version to 0.2.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ironclaw_safety crate version from 0.1.0 to 0.2.0 across various Cargo.toml and Cargo.lock files. It also removes the publish = false setting from the crates/ironclaw_safety/Cargo.toml and removes the package entry from release-plz.toml. A critical issue was identified regarding the removal of publish = false for ironclaw_safety. The crate currently uses edition = "2024" and rust-version = "1.92", which are unstable and unreleased. Publishing the crate in this state would make it unusable for most users due to its reliance on unstable features like let-chains. The reviewer suggests either changing the edition to 2021 and refactoring the code, or waiting until the required Rust version (at least 1.87.0) is stable before publishing.

license = "MIT OR Apache-2.0"
homepage = "https://github.com/nearai/ironclaw"
repository = "https://github.com/nearai/ironclaw"
publish = false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Removing publish = false will make this crate available on crates.io. However, the current Cargo.toml specifies edition = "2024" and rust-version = "1.92".

The 2024 edition is not yet stable, and Rust 1.92 is a future, unreleased version. Publishing a crate that requires such a new, unstable toolchain will make it unusable for the vast majority of the Rust ecosystem, as it cannot be built with stable Rust. For example, the code uses let-chains, which are only stabilized in the unreleased Rust 1.87.0.

This will cause significant build failures for anyone trying to use ironclaw_safety as a dependency from crates.io.

Before publishing, please either:

  1. Change edition to 2021 and refactor the code to not use features from unreleased Rust versions (like let-chains).
  2. Wait until the required Rust version (at least 1.87.0) is stable before publishing this crate.

Given the fix nature of this PR, option 1 is likely the intended path.

@henrypark133

Copy link
Copy Markdown
Collaborator Author

Need to merge to unblock release.

@henrypark133
henrypark133 merged commit ab67f02 into main Mar 26, 2026
30 of 31 checks passed
@henrypark133
henrypark133 deleted the codex/publish-ironclaw-safety branch March 26, 2026 01:21
bkutasi pushed a commit to bkutasi/ironclaw that referenced this pull request Mar 28, 2026
drchirag1991 pushed a commit to drchirag1991/ironclaw that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: dependencies Dependency updates size: S 10-49 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants