fix: allow publishing ironclaw_common - #1657
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical release blocker by making the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Makes the ironclaw_common workspace crate publishable on crates.io so release automation (e.g., release-plz) can publish it ahead of crates that depend on it, unblocking registry resolution without changing the crate layout.
Changes:
- Removes
publish = falsefromcrates/ironclaw_common/Cargo.tomlto allow publishing the crate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request makes the ironclaw_common crate publishable by removing the publish = false flag from its Cargo.toml. The review feedback highlights that while this change correctly addresses the publishability of ironclaw_common, the ironclaw crate's path dependency on ironclaw_safety (which is configured not to be published) will likely cause a similar release blocker. To fully resolve the issue, ironclaw_safety should also be made publishable.
| license = "MIT OR Apache-2.0" | ||
| homepage = "https://github.com/nearai/ironclaw" | ||
| repository = "https://github.com/nearai/ironclaw" | ||
| publish = false |
There was a problem hiding this comment.
This change correctly makes ironclaw_common publishable, which is a necessary step to unblock the release. However, the ironclaw crate also has a path dependency on ironclaw_safety. The release-plz.toml configuration indicates that ironclaw_safety is not to be published. This will likely cause the release to fail with the same error you are fixing for ironclaw_common.
To fully resolve the release blocker, ironclaw_safety should also be made publishable.
Summary
Why
The Release-plz release job is failing because ironclaw depends on ironclaw_common, but Cargo cannot resolve ironclaw_common from crates.io while it is marked publish = false.
Verification