Skip to content

fix: allow publishing ironclaw_common - #1657

Merged
henrypark133 merged 1 commit into
mainfrom
codex/publish-ironclaw-common
Mar 26, 2026
Merged

henrypark133 merged 1 commit into
mainfrom
codex/publish-ironclaw-common

Conversation

@henrypark133

@henrypark133 henrypark133 commented Mar 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • remove publish = false from crates/ironclaw_common/Cargo.toml
  • make ironclaw_common publishable so release-plz can publish it before ironclaw
  • keep the fix scoped to the release blocker without refactoring the crate layout

Why

The Release-plz release job is failing because ironclaw depends on ironclaw_common, but Cargo cannot resolve ironclaw_common from crates.io while it is marked publish = false.

Verification

  • cargo publish --dry-run --allow-dirty --manifest-path crates/ironclaw_common/Cargo.toml

Copilot AI review requested due to automatic review settings March 26, 2026 00:55
@github-actions github-actions Bot added size: XS < 10 changed lines (excluding docs) risk: low Changes to docs, tests, or low-risk modules labels Mar 26, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical release blocker by making the ironclaw_common crate publishable. Previously, ironclaw_common was marked as publish = false, which prevented release-plz from publishing it. This blockage caused the release-plz job to fail because the ironclaw crate depends on ironclaw_common. The change ensures that ironclaw_common can be published, thereby unblocking the ironclaw release process.

Highlights

  • Crate Publishability: Removed the publish = false directive from crates/ironclaw_common/Cargo.toml to allow the crate to be published.
  • Release Process Unblocked: Enabled release-plz to successfully publish ironclaw_common before ironclaw, resolving a dependency issue that was causing release failures.
  • Scope of Change: Ensured the fix was narrowly focused on addressing the immediate release blocker without introducing broader refactoring of the crate structure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes the ironclaw_common workspace crate publishable on crates.io so release automation (e.g., release-plz) can publish it ahead of crates that depend on it, unblocking registry resolution without changing the crate layout.

Changes:

  • Removes publish = false from crates/ironclaw_common/Cargo.toml to allow publishing the crate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes the ironclaw_common crate publishable by removing the publish = false flag from its Cargo.toml. The review feedback highlights that while this change correctly addresses the publishability of ironclaw_common, the ironclaw crate's path dependency on ironclaw_safety (which is configured not to be published) will likely cause a similar release blocker. To fully resolve the issue, ironclaw_safety should also be made publishable.

license = "MIT OR Apache-2.0"
homepage = "https://github.com/nearai/ironclaw"
repository = "https://github.com/nearai/ironclaw"
publish = false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change correctly makes ironclaw_common publishable, which is a necessary step to unblock the release. However, the ironclaw crate also has a path dependency on ironclaw_safety. The release-plz.toml configuration indicates that ironclaw_safety is not to be published. This will likely cause the release to fail with the same error you are fixing for ironclaw_common.

To fully resolve the release blocker, ironclaw_safety should also be made publishable.

@henrypark133
henrypark133 merged commit f02345f into main Mar 26, 2026
30 of 31 checks passed
@henrypark133
henrypark133 deleted the codex/publish-ironclaw-common branch March 26, 2026 00:58
bkutasi pushed a commit to bkutasi/ironclaw that referenced this pull request Mar 28, 2026
drchirag1991 pushed a commit to drchirag1991/ironclaw that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules size: XS < 10 changed lines (excluding docs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants