Skip to content

fix(setup): remove nonexistent webhook secret command hint #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrypark133 merged 2 commits into from
Mar 18, 2026
Merged

fix(setup): remove nonexistent webhook secret command hint #1349

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea4971e
fix(setup): remove nonexistent webhook secret command hint
G7CNF Mar 18, 2026
14ff517
test(setup): cover webhook secret onboarding hint
G7CNF Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/setup/channels.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,9 @@ pub async fn setup_http(secrets: &SecretsContext) -> Result<HttpSetupResult, Cha
.save_secret("http_webhook_secret", &SecretString::from(secret))
.await?;
print_success("Webhook secret generated and saved to database");
print_info("Retrieve it later with: ironclaw secret get http_webhook_secret");
print_info(
"The secret is stored in the encrypted secrets database and will be loaded automatically on startup.",

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Don't claim startup auto-loads the stored HTTP secret

When users enable the HTTP webhook in the wizard and accept auto-generation, this new message says the saved secret will be loaded on the next start, but the startup path never does that. ChannelsConfig::resolve() still reads the webhook secret only from HTTP_WEBHOOK_SECRET (src/config/channels.rs:99-106), AppBuilder::init_secrets() injects only LLM keys (src/app.rs:230-243), and the DB-backed http_webhook_secret is injected only inside the SIGHUP reload handler (src/main.rs:807-821). On a fresh process, HttpChannel::start() still errors with HTTP webhook secret is required (src/channels/http.rs:651-656), so this guidance leaves the wizard-generated configuration unusable unless the user also exports the secret manually.

Useful? React with 👍 / 👎.

);
}

print_success(&format!("HTTP webhook will listen on {}:{}", host, port));
Expand Down
Loading