fix(setup): remove nonexistent webhook secret command hint - #1349
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the user onboarding experience by correcting misleading information related to webhook secret management. It removes an obsolete command hint and provides an accurate description of how webhook secrets are stored and utilized, ensuring users receive clear and current guidance during the setup process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully addresses the stated objective of removing a nonexistent command hint and replacing it with accurate information regarding the webhook secret's storage and loading mechanism. The updated message provides clear and correct guidance to the user.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea4971e67f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| print_info( | ||
| "The secret is stored in the encrypted secrets database and will be loaded automatically on startup.", |
There was a problem hiding this comment.
Don't claim startup auto-loads the stored HTTP secret
When users enable the HTTP webhook in the wizard and accept auto-generation, this new message says the saved secret will be loaded on the next start, but the startup path never does that. ChannelsConfig::resolve() still reads the webhook secret only from HTTP_WEBHOOK_SECRET (src/config/channels.rs:99-106), AppBuilder::init_secrets() injects only LLM keys (src/app.rs:230-243), and the DB-backed http_webhook_secret is injected only inside the SIGHUP reload handler (src/main.rs:807-821). On a fresh process, HttpChannel::start() still errors with HTTP webhook secret is required (src/channels/http.rs:651-656), so this guidance leaves the wizard-generated configuration unusable unless the user also exports the secret manually.
Useful? React with 👍 / 👎.
henrypark133
left a comment
There was a problem hiding this comment.
Review: Remove misleading webhook secret command hint
Clean fix. The old ironclaw secret get http_webhook_secret command doesn't exist — this replaces it with an accurate description of the auto-load behavior.
Positives:
- Extracts hint into
http_webhook_secret_hint()for testability - Regression test verifies both the new content and absence of the old command
- Minimal, focused change
LGTM.
* fix(setup): remove nonexistent webhook secret command hint * test(setup): cover webhook secret onboarding hint
* fix(setup): remove nonexistent webhook secret command hint * test(setup): cover webhook secret onboarding hint
Summary
ironclaw secretsubcommand.Validation
cargo fmt --all -- --checkcargo check -qCloses #1308