[Migration] deprecate darkside props #3656
Conversation
|
Storybook demo / Chromatic7096cf5a2 | 91 components | 135 stories |
JulianNymark
changed the title
There was a problem hiding this comment.
Might make sense to rename spacing key for the group to something more fitting.
There was a problem hiding this comment.
Yeah, can make a whole separate one for darkside? 🤔
| import type { API, FileInfo } from "jscodeshift"; | ||
| import { getLineTerminator } from "../../../utils/lineterminator"; | ||
| import removePropsFromComponent from "../../../utils/removeProps"; | ||
| import { findComponentImport } from "../../spacing/spacing.utils"; |
There was a problem hiding this comment.
@KenAJoh should we move all the utility functions inside the spacing directory out to more generic utils?
There was a problem hiding this comment.
If you see the use for them elsewhere, sure 👍
There was a problem hiding this comment.
I only currently use one of the more generic ast crawling functions you made, but i moved the whole group of them into a separate ast.ts. Feels like that makes the most sense 💭
|
Would be nice to merge this and use the utils further in the current wip migration (Box) 🤩 Will merge ASAP as it's approved |
Description
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")