Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] Deprecate listprops title, headingTag and description #3537

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Feb 1, 2025

Description

Also removed built-in spacing for List in darkside based on Figma updates and previous discussions within the team. Would like to remove the redundant div wrapping now, but will break some code in production now so need to wait for that until an actual major-release.

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@KenAJoh KenAJoh self-assigned this Feb 1, 2025
Copy link

changeset-bot bot commented Feb 1, 2025

🦋 Changeset detected

Latest commit: f8c9957

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Storybook demo / Chromatic

7792e4f6a | 91 components | 135 stories

Copy link
Contributor

@it-vegard it-vegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KenAJoh KenAJoh merged commit 2bba7af into main Feb 5, 2025
6 checks passed
@KenAJoh KenAJoh deleted the deprecate-listprops branch February 5, 2025 10:24
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants