Skip to content

[Backport] Add expanded documentation to AdapterInterface::update#1

Closed
navarr wants to merge 1 commit into2.2-developfrom
2.2-develop-PR-port-14755
Closed

[Backport] Add expanded documentation to AdapterInterface::update#1
navarr wants to merge 1 commit into2.2-developfrom
2.2-develop-PR-port-14755

Conversation

@navarr
Copy link
Copy Markdown
Owner

@navarr navarr commented Apr 19, 2018

Original Pull Request

magento#14755
This adds a long description to AdapterInterface::update detailing how the $where parameter works

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This adds a long description to AdapterInterface::update detailing how the `$where` parameter works
@navarr navarr closed this Apr 19, 2018
@navarr navarr deleted the 2.2-develop-PR-port-14755 branch June 27, 2018 20:38
navarr pushed a commit that referenced this pull request Jul 31, 2018
[Forwardport] Fixed typo mistake in function comment
navarr pushed a commit that referenced this pull request Jul 31, 2018
…nto#15726

 - Merge Pull Request magento#15726 from sanjay-wagento/magento2:2.3-develop-PR-port-13026
 - Merged commits:
   1. ce176d2
navarr pushed a commit that referenced this pull request Jul 31, 2018
Accepted Public Pull Requests:
 - magento#16275: Simplified TypeProcessor (by @joni-jones)
 - magento#15842: [Forwardport] Add missing table aliases to fields mapping for Customer Group filter� (by @hitesh-wagento)
 - magento#15744: [Forwardport] [BUGFIX] magento#15564 Generated admin API token expires immediately (by @vijay-wagento)
 - magento#15726: Forwardport] Feature space between category page #1 (by @sanjay-wagento)
 - magento#15698: [Forwardport] Variant product image in sidebar wishlist block (by @dmytro-ch)
 - magento#15672: [FORWARDPORT magento#15097] Add field to filter to collection (by @dverkade)
 - magento#16256: magento#15255 unlock customer after password reset (by @vgelani)
 - magento#16246: [Forwardport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP (by @lfluvisotto)
 - magento#16224: [Forwardport] Correct return type of methods and typo correction. (by @saurabh-aureate)
 - magento#16225: Navigation dropdown caret icon. (by @tejash-wagento)
 - magento#15980: Use correct error message for duplicate error key in product import (by @denteblu)


Fixed GitHub Issues:
 - magento#15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined (reported by @radio) has been fixed in magento#15842 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. 0f23ed7

 - magento#15564: 2.2.4 Created admin token has no access (reported by @krukas) has been fixed in magento#15744 by @vijay-wagento in 2.3-develop branch
   Related commits:
     1. 7f34b22
     2. 349d178

 - magento#12601: A space between the category page and the main footer when applying specific settings (reported by @wd7080) has been fixed in magento#15726 by @sanjay-wagento in 2.3-develop branch
   Related commits:
     1. ce176d2

 - magento#15255: Customer who exceeded max login failures not able to login even after reset password (reported by @tizzyguy87) has been fixed in magento#16256 by @vgelani in 2.3-develop branch
   Related commits:
     1. a108233
navarr pushed a commit that referenced this pull request Jul 31, 2018
[Forwardport] When searching for the title if search for all the segments that has …
navarr pushed a commit that referenced this pull request Nov 16, 2018
navarr pushed a commit that referenced this pull request Nov 16, 2018
Remove unnecesary "header" block redeclaration
navarr pushed a commit that referenced this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant