Skip to content

Add expanded documentation to AdapterInterface::update#14755

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
navarr:navarr-patch-1
Apr 20, 2018
Merged

Add expanded documentation to AdapterInterface::update#14755
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
navarr:navarr-patch-1

Conversation

@navarr
Copy link
Copy Markdown
Contributor

@navarr navarr commented Apr 18, 2018

This adds a long description to AdapterInterface::update detailing how the $where parameter works

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This adds a long description to AdapterInterface::update detailing how the `$where` parameter works
@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Apr 18, 2018

CLA assistant check
All committers have signed the CLA.

@navarr navarr changed the base branch from 2.2-develop to 2.3-develop April 18, 2018 12:33
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 18, 2018
@dmanners
Copy link
Copy Markdown
Contributor

Hi @navarr thank you for this PR. I will process this now for you.

@dmanners
Copy link
Copy Markdown
Contributor

Hi @navarr I am having a few issues with the branch. Is this branch up to date with the latest 2.3-develop branch?

@navarr
Copy link
Copy Markdown
Contributor Author

navarr commented Apr 18, 2018

@dmanners Yes. This branch is based off commit f5debf0 which is the latest in the 2.3-develop branch.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @navarr. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants