Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump legacy nats client nuid dependency & remove old client from CI runs #1367

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jan 28, 2025

This is required for the old client to build.

reference issue: casualjim/rs-nuid#12

@Jarema
Copy link
Member Author

Jarema commented Jan 28, 2025

oh, that was not that simple.

@Jarema Jarema marked this pull request as draft January 28, 2025 10:00
@Jarema Jarema changed the title Bump legacy nats client nuid dependency Bump legacy nats client nuid dependency & remove old client from CI runs Jan 29, 2025
@Jarema Jarema force-pushed the bump-legacy-nats-nuid-dep branch from b6d7cb3 to 92ab6ee Compare January 29, 2025 08:39
@Jarema Jarema marked this pull request as ready for review January 29, 2025 08:41
@Jarema Jarema requested review from piotrpio and caspervonb January 29, 2025 09:12
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema force-pushed the bump-legacy-nats-nuid-dep branch from 92ab6ee to 8915d65 Compare January 29, 2025 10:57
@Jarema Jarema merged commit 755e1f0 into main Jan 29, 2025
12 checks passed
@Jarema Jarema deleted the bump-legacy-nats-nuid-dep branch January 29, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants