Disable legacy nats in CI

Signed-off-by: Tomasz Pietrek <[email protected]>
nats-io · Jan 29, 2025 · 755e1f0 · 755e1f0
1 parent edd386c
commit 755e1f0
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 5 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -11,6 +11,9 @@ env:
 
 jobs:
   benchmark:
+    defaults:
+      run:
+        working-directory: ./async-nats
     runs-on: ubuntu-latest
     steps:
       - name: Check out repository
@@ -36,7 +39,7 @@ jobs:
         with:
           shared-key: ${{ runner.os }}-${{ steps.install-rust.outputs.cachekey }}-${{ hashFiles('**/Cargo.toml') }}
       - name: Build the package # for caching
-        run: cargo build --all --all-targets
+        run: cargo build --all-targets
 
       - name: Run benchmarks
         env:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -21,6 +21,9 @@ defaults:
 
 jobs:
   test_matrix:
+    defaults:
+      run:
+        working-directory: ./async-nats
     name: test (${{ matrix.os }} / stable)
     runs-on: ${{ matrix.os }}
     strategy:
@@ -55,7 +58,8 @@ jobs:
           cache-on-failure: true
       - name: Build all packages
         id:   build-packages
-        run:  cargo build --all --all-targets
+        run:  |
+          cargo build --all-targets
 
       - name: Setup deno for service tests
         if: ${{ matrix.os }} != windows-latest
@@ -91,6 +95,9 @@ jobs:
         run: cargo fmt -- --check
 
   check_lint:
+    defaults:
+      run:
+        working-directory: ./async-nats
     name: check linter (ubuntu-latest / stable)
     runs-on: ubuntu-latest
     steps:
@@ -109,9 +116,12 @@ jobs:
           save-if: false # the linter only run checks but not builds, so we don't have the full build to be cached.
 
       - name: Run linter
-        run: cargo clippy --benches --tests --examples --all-features --workspace --exclude nats -- --deny clippy::all
+        run: cargo clippy --benches --tests --examples --all-features  -- --deny clippy::all
 
   check_docs:
+    defaults:
+      run:
+        working-directory: ./async-nats
     name: check docs (ubuntu-latest / stable)
     runs-on: ubuntu-latest
     steps:
@@ -131,6 +141,9 @@ jobs:
         run: cargo doc --no-deps --all-features
 
   check_features:
+    defaults:
+      run:
+        working-directory: ./async-nats
     name: check feature flags (ubuntu-latest / stable)
     runs-on: ubuntu-latest
     steps:
@@ -163,6 +176,9 @@ jobs:
           command-arguments: licenses
 
   check_msrv:
+    defaults:
+      run:
+        working-directory: ./async-nats
     name: check minimal supported rust version (ubuntu-latest / msrv)
     runs-on: ubuntu-latest
     steps:
@@ -185,6 +201,9 @@ jobs:
           cargo +${{ steps.install-rust.outputs.name }} check
 
   check_examples:
+    defaults:
+      run:
+        working-directory: ./async-nats
     name: check examples (ubuntu-latest / stable)
     runs-on: ubuntu-latest
     steps:
@@ -231,6 +250,9 @@ jobs:
         run: cargo spellcheck --code 1
 
   check_min_versions:
+    defaults:
+      run:
+        working-directory: ./async-nats
     name: check minimal versions of transitive dependencies (ubuntu-latest / stable)
     runs-on: ubuntu-latest
     steps:

diff --git a/async-nats/src/jetstream/consumer/push.rs b/async-nats/src/jetstream/consumer/push.rs
@@ -478,7 +478,7 @@ impl IntoConsumerConfig for OrderedConfig {
 }
 
 impl Consumer<OrderedConfig> {
-    pub async fn messages<'a>(self) -> Result<Ordered, StreamError> {
+    pub async fn messages(self) -> Result<Ordered, StreamError> {
         let subscriber = self
             .context
             .client

diff --git a/async-nats/src/jetstream/object_store/mod.rs b/async-nats/src/jetstream/object_store/mod.rs
@@ -671,7 +671,7 @@ impl ObjectStore {
     /// # Ok(())
     /// # }
     /// ```
-    pub async fn add_link<'a, T, O>(&self, name: T, object: O) -> Result<ObjectInfo, AddLinkError>
+    pub async fn add_link<T, O>(&self, name: T, object: O) -> Result<ObjectInfo, AddLinkError>
     where
         T: ToString,
         O: AsObjectInfo,