Skip to content

Fix telemetry header readonly error#719

Merged
mtmk merged 15 commits into
mainfrom
fix-publish-telemetry
Jan 27, 2025
Merged

Fix telemetry header readonly error#719
mtmk merged 15 commits into
mainfrom
fix-publish-telemetry

Conversation

@mtmk

@mtmk mtmk commented Jan 17, 2025

Copy link
Copy Markdown
Member

@mtmk mtmk mentioned this pull request Jan 17, 2025
Closed
mtmk
mtmk commented Jan 17, 2025
View reviewed changes
Comment thread src/NATS.Client.Core/NatsConnection.Publish.cs
if (Telemetry.HasListeners())
{
using var activity = Telemetry.StartSendActivity($"{SpanDestinationName(subject)} {Telemetry.Constants.PublishActivityName}", this, subject, replyTo);
Telemetry.AddTraceContextHeaders(activity, ref headers);

@mtmk mtmk Jan 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bug fix

@mtmk mtmk added the bug fix label Jan 20, 2025
@mtmk
mtmk requested a review from scottf January 20, 2025 14:35
@mtmk mtmk self-assigned this Jan 24, 2025
@mtmk mtmk added the priority label Jan 25, 2025
scottf
scottf approved these changes Jan 27, 2025
View reviewed changes

@scottf scottf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk
mtmk merged commit ead42bb into main Jan 27, 2025
@mtmk
mtmk deleted the fix-publish-telemetry branch January 27, 2025 16:38
mtmk added a commit that referenced this pull request Jan 27, 2025
@mtmk
Release 2.5.7
c138a1f 
* Fix telemetry header readonly error (#719)
* Add NatsClient to DI (#689)
* Add callback to NatsAuthOpts that allows refreshing a Token (#712)
* Implement Lame Duck Mode Event Handler (#716)
* Add CreateOrUpdateStoreAsync (#707)
@mtmk mtmk mentioned this pull request Jan 27, 2025
Merged
mtmk added a commit that referenced this pull request Jan 27, 2025
@mtmk
Release 2.5.7 (#729)
7177140 
* Fix telemetry header readonly error (#719)
* Add NatsClient to DI (#689)
* Add callback to NatsAuthOpts that allows refreshing a Token (#712)
* Implement Lame Duck Mode Event Handler (#716)
* Add CreateOrUpdateStoreAsync (#707)
This was referenced Nov 3, 2025
Closed
Merged
@dependabot dependabot Bot mentioned this pull request Mar 2, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Mar 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottf scottf scottf approved these changes

Assignees

@mtmk mtmk

Labels

bug fix priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update on ReadOnly Headers after Retry

2 participants

@mtmk @scottf