Implement Lame Duck Mode Event Handler#716
Merged
Merged
Conversation
pzajaczkowski
force-pushed
the
ldm-event-handler
branch
from
January 15, 2025 18:24
edda667 to
15f7ac2
Compare
mtmk
reviewed
Jan 16, 2025
Member
|
@pzajaczkowski thanks for the PR. long overdue that issue ;)
I think that's fine.
Potentially passing the host might be a interesting. EDIT: What do you think about passing |
mtmk
reviewed
Jan 16, 2025
mtmk
reviewed
Jan 17, 2025
mtmk
reviewed
Jan 21, 2025
The LDM request feature test uses added to server version 2.10.
mtmk
added a commit
that referenced
this pull request
Jan 27, 2025
Merged
mtmk
added a commit
that referenced
this pull request
Jan 27, 2025
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #23
I had two ideas for approaching this issue:
WritableServerInfoproperty and add setter, that will check if LDM has changed totrueNatsConnectionand invoke it directly fromNatsReadProtocolProcessorafter recieving INFO from server with LDM.I decided to go with first option.
There is one thing i am not sure of: should anything be passed as argument to the
LameDuckModeActivatedevent? Currently, it is an empty string.