Fix release workflow#1106
Merged
Merged
Conversation
The workflow previously triggered on push to main, meaning any merged PR that changed version.txt would push packages to NuGet. Switch to the release-published event so publishing requires a manual GitHub release, matching the nkeys.net approach.
Contributor
|
Claude finished @mtmk's task in 1m 57s —— View job PR Review: Fix release workflow
The core change is a clear improvement: switching from One issue worth fixing:
Other observations (no action needed):
|
This was referenced Apr 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow triggered on push to main, so any merged PR that changed version.txt would push packages to NuGet. Switch to the
release: publishedevent so publishing requires a maintainer to create a GitHub release, and validate the tag matches version.txt before packing.