FIXED unobserved exceptions surfacing due to unobserved tcs.#1051
Merged
Conversation
Member
|
@me064 thanks for the PR it's looking good. The test seems to be failing for some reason. Once you fix the test I can have one last look then merge. |
me064
marked this pull request as draft
January 27, 2026 13:39
Signed-off-by: me064 <johannes.kull93@gmail.com> Fixed unobserved exceptions from ProtocolTest surfacing in AuthErrorTest minor improvements Signed-off-by: me064 <johannes.kull93@gmail.com>
me064
force-pushed
the
fix-unobserved-exceptions-from-tcs
branch
from
January 27, 2026 14:35
25fa671 to
0a4fb1e
Compare
me064
marked this pull request as ready for review
January 27, 2026 14:42
mtmk
approved these changes
Jan 28, 2026
mtmk
added a commit
that referenced
this pull request
Jan 30, 2026
mtmk
added a commit
that referenced
this pull request
Jan 30, 2026
mtmk
added a commit
that referenced
this pull request
Feb 10, 2026
Changes in this release: * Fix StreamSourceInfo.Active handle -1 correctly (#1058) * Fix NatsUri not reflecting host/port changes from OnConnectingAsync hook (#997) Chanfes from preview.2 * Fix OTel activity leak in Direct request mode (#1047) * Fix subject UTF-8 encoding (#1054) * Add SlowConsumerDetected event and warnings (#1052) * Fixed unobserved exceptions surfacing due to unobserved tcs. (#1051) Changes from preview.1 * Fix and improve build for docs ci error (#1040) * resolves: 1035 - Use ConnectTimeout when awaiting INFO signal (#1039) * Fix slow consumer blocking (#1041)
Merged
mtmk
added a commit
that referenced
this pull request
Feb 10, 2026
Changes in this release: * Fix StreamSourceInfo.Active handle -1 correctly (#1058) * Fix NatsUri not reflecting host/port changes from OnConnectingAsync hook (#997) Chanfes from preview.2 * Fix OTel activity leak in Direct request mode (#1047) * Fix subject UTF-8 encoding (#1054) * Add SlowConsumerDetected event and warnings (#1052) * Fixed unobserved exceptions surfacing due to unobserved tcs. (#1051) Changes from preview.1 * Fix and improve build for docs ci error (#1040) * resolves: 1035 - Use ConnectTimeout when awaiting INFO signal (#1039) * Fix slow consumer blocking (#1041)
This was referenced Feb 16, 2026
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1050
Fixed unobserved exceptions surfacing from
TaskCompletionSourceobjects setting exceptions but not observing them.The fix includes an extension method
TrySetObservedExceptionforTaskCompletionSourcethat sets the exception and immediately observes it to avoid any unobserved exceptions. All usages ofTrySetExceptionhas been replaced withTrySetObservedException.Two new tests have been added and one unrelated test has been modified due to it causing unobserved exceptions that are then caught in one of the new tests, causing it to fail.
My recommendation for the future would be to create a global garbage collection test or similar to ensure no future unobserved exceptions appear throughout the library.