resolves: 1035 - Use ConnectTimeout when awaiting INFO signal#1039
Merged
mtmk merged 1 commit intoJan 14, 2026
Merged
Conversation
mtmk
added a commit
that referenced
this pull request
Jan 14, 2026
mtmk
added a commit
that referenced
this pull request
Feb 10, 2026
Changes in this release: * Fix StreamSourceInfo.Active handle -1 correctly (#1058) * Fix NatsUri not reflecting host/port changes from OnConnectingAsync hook (#997) Chanfes from preview.2 * Fix OTel activity leak in Direct request mode (#1047) * Fix subject UTF-8 encoding (#1054) * Add SlowConsumerDetected event and warnings (#1052) * Fixed unobserved exceptions surfacing due to unobserved tcs. (#1051) Changes from preview.1 * Fix and improve build for docs ci error (#1040) * resolves: 1035 - Use ConnectTimeout when awaiting INFO signal (#1039) * Fix slow consumer blocking (#1041)
Merged
mtmk
added a commit
that referenced
this pull request
Feb 10, 2026
Changes in this release: * Fix StreamSourceInfo.Active handle -1 correctly (#1058) * Fix NatsUri not reflecting host/port changes from OnConnectingAsync hook (#997) Chanfes from preview.2 * Fix OTel activity leak in Direct request mode (#1047) * Fix subject UTF-8 encoding (#1054) * Add SlowConsumerDetected event and warnings (#1052) * Fixed unobserved exceptions surfacing due to unobserved tcs. (#1051) Changes from preview.1 * Fix and improve build for docs ci error (#1040) * resolves: 1035 - Use ConnectTimeout when awaiting INFO signal (#1039) * Fix slow consumer blocking (#1041)
This was referenced Feb 16, 2026
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: Issue #1035
After a successful NATS Connection, upon loss of that connection the configured retry policy/settings are executed. During this reconnect/retry loop, if the NATS Server is unreachable, we land on NatsConnection.cs:line:529, specifically the
WaitAsynchanging on thewaitForInfoSignalTask. This respects the timeout provided viaRequestTimeoutof the connection'sNatsOpts.In my use-case, the default
RequestTimeoutneeds to be relatively long, on the order of ~1 minute. That led to observing Retries seemingly hanging well beyond expectations, I had expected the timeout to be theConnectTimeout, not theRequestTimeout.This Change
This PR swaps the timeout from
NatsOpts.RequestTimeoutto the expectedNatsOpts.ConnectTimeout.