Add Publish Timeout on Disconnect

[mtmk]

• See also Publishing on Jet Stream hangs indefinitely if the server is unreachable #1000

Put behind an option to not break existing behavior.

[scottf]

LGTM

[mtmk]

@paagamelo2 does this work for you?

[paagamelo2]

@paagamelo2 does this work for you?

Apologies, haven't had a chance to try this out yet. Will do between today and tomorrow!

[paagamelo2]

@mtmk I'm seeing the same behavior as before, despite using the new PublishTimeoutOnDisconnected flag.

I see in your tests you wait for the reconnection loop to kick in, which I don't. The only other difference is that I'm using Testcontainers. I'd be surprised if any of that makes a difference though.

This is essentially what I'm doing:

[Fact]
public async Task ExperimentWithRealNats()
{
    await using var nats = new NatsBuilder().Build();
    await nats.StartAsync();

    await using var client = new NatsClient(nats.GetConnectionString());
    var js = client.CreateJetStreamContext(new NatsJSOpts(new NatsOpts
    {
        CommandTimeout = TimeSpan.FromSeconds(3),
        PublishTimeoutOnDisconnected = true,
    }));

    await js.CreateStreamAsync(new StreamConfig("ORDERS", ["orders.>"]));

    await nats.StopAsync();

    try
    {
        await js.PublishAsync("orders.1", "this is my order :)");
    }
    catch (Exception ex)
    {
        Debugger.Break(); // <- never hit
    }
}

Do you spot anything wrong?

[mtmk]

Thanks for checking this @paagamelo2

Can you try passing the opts to client:

    await using var client = new NatsClient(new NatsOpts
    {
        Url = nats.GetConnectionString(),
        CommandTimeout = TimeSpan.FromSeconds(3),
        PublishTimeoutOnDisconnected = true,
    });
    var js = client.CreateJetStreamContext();

[paagamelo2]

@mtmk cheers, that works as expected for me!