Skip to content

(2.14) [FIXED] Filestore delete map race #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilalexander merged 1 commit into from
Nov 18, 2025
+7 −1
Merged

(2.14) [FIXED] Filestore delete map race #7560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion server/filestore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10669,8 +10669,14 @@ func (fs *fileStore) deleteBlocks() DeleteBlocks {
// deleteMap returns all interior deletes for each block based on the mb.dmap.
// Specifically, this will not contain any deletes for blocks that have been removed.
// This is useful to know whether a tombstone is still relevant and marked as deleted by an active block.
// All blocks should be at least read locked.
// No locks should be held.
func (fs *fileStore) deleteMap() (dmap avl.SequenceSet) {
fs.mu.RLock()
defer fs.mu.RUnlock()

fs.readLockAllMsgBlocks()
defer fs.readUnlockAllMsgBlocks()

for _, mb := range fs.blks {
if mb.dmap.Size() > 0 {
mb.dmap.Range(func(seq uint64) bool {
Expand Down
Loading