Skip to content

(2.14) [FIXED] Filestore delete map race#7560

Merged
neilalexander merged 1 commit intomainfrom
maurice/fs-tomb-race
Nov 18, 2025
Merged

(2.14) [FIXED] Filestore delete map race#7560
neilalexander merged 1 commit intomainfrom
maurice/fs-tomb-race

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

Fixes a data race introduced in #7387:

WARNING: DATA RACE
Read at 0x00c0002d17f0 by goroutine 527:
  github.com/nats-io/nats-server/v2/server/avl.(*SequenceSet).Range()
      server/avl/seqset.go:125 +0x3b
  github.com/nats-io/nats-server/v2/server.(*fileStore).deleteMap()
      server/filestore.go:10676 +0x164

Previous write at 0x00c0002d17f0 by goroutine 182:
  github.com/nats-io/nats-server/v2/server/avl.(*SequenceSet).Insert()
      server/avl/seqset.go:45 +0x6d
  github.com/nats-io/nats-server/v2/server.(*fileStore).PurgeEx()
      server/filestore.go:8626 +0x1b0c

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 18, 2025 09:45
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 7cdd5cf into main Nov 18, 2025
111 of 114 checks passed
@neilalexander neilalexander deleted the maurice/fs-tomb-race branch November 18, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants