Skip to content

[FIXED] Processes config file during embeded server initialization. #7093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yixianOu wants to merge 1 commit into from
Closed

[FIXED] Processes config file during embeded server initialization. #7093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,9 @@ func New(opts *Options) *Server {
// The provided Options type should not be re-used afterwards.
// Either use Options.Clone() to pass a copy, or make a new one.
func NewServer(opts *Options) (*Server, error) {
if opts.ConfigFile != _EMPTY_ {
opts.ProcessConfigFile(opts.ConfigFile)
}
Copy link
Copy Markdown
Contributor

@ripienaar ripienaar Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be surprising if NewServer() changes my passed options like this without some opt-in.

It might be better to add a helper function like NewServerFromConfig(file string) or something like that? Else maybe gate this behaviour on having passed a nil options with clear docs callout about that - but that doesn't seem so nice.

Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mentioned issue also uses some other options instead of just the config file.
Why not call opts.ProcessConfigFile(opts.ConfigFile) right before calling NewServer on the options when embedding? (that's the same thing the server already does when combining CLI flags, etc.)

setBaselineOptions(opts)

// Process TLS options, including whether we require client certificates.
Expand Down
Loading