[FIXED] Processes config file during embeded server initialization.#7093
Closed
yixianOu wants to merge 1 commit intonats-io:mainfrom
Closed
[FIXED] Processes config file during embeded server initialization.#7093yixianOu wants to merge 1 commit intonats-io:mainfrom
yixianOu wants to merge 1 commit intonats-io:mainfrom
Conversation
Signed-off-by: orician <lzjzxOYX201905@gmail.com>
yixianOu
changed the title
ripienaar
reviewed
Jul 23, 2025
| func NewServer(opts *Options) (*Server, error) { | ||
| if opts.ConfigFile != _EMPTY_ { | ||
| opts.ProcessConfigFile(opts.ConfigFile) | ||
| } |
Contributor
There was a problem hiding this comment.
it would be surprising if NewServer() changes my passed options like this without some opt-in.
It might be better to add a helper function like NewServerFromConfig(file string) or something like that? Else maybe gate this behaviour on having passed a nil options with clear docs callout about that - but that doesn't seem so nice.
Member
There was a problem hiding this comment.
The mentioned issue also uses some other options instead of just the config file.
Why not call opts.ProcessConfigFile(opts.ConfigFile) right before calling NewServer on the options when embedding? (that's the same thing the server already does when combining CLI flags, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7092
Edited the NewServer function in the server package , server.go file. Using the ProcessConfigFile method of the Options type, to enable the embeded nats-server to read the config file
Signed-off-by: orician lzjzxOYX201905@gmail.com