[FIXED] NRG: Monotonic heartbeat and quorum tracking#6999
Merged
neilalexander merged 1 commit intomainfrom Jun 23, 2025
Merged
Conversation
Converting the timestamps to `UnixNano` meant that all of these operations were using wall-clock rather than monotonic time, which meant that these operations were not safe against wall-clock drifts or NTP adjustments. This could result in unexpected loss of quorum. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/nrgpstime
branch
from
1725cad to
2e2d40c
Compare
MauriceVanVeen
approved these changes
Jun 23, 2025
wallyqs
changed the title
neilalexander
added a commit
that referenced
this pull request
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting the timestamps to
UnixNanomeant that all of these operations were using wall-clock rather than monotonic time, which meant that these operations were not safe against wall-clock drifts or NTP adjustments. This could result in unexpected loss of quorum.Signed-off-by: Neil Twigg neil@nats.io