[FIXED] Propagate stream interest policy changes to consumers in all cases#6995
Merged
neilalexander merged 1 commit intomainfrom Jun 20, 2025
Merged
[FIXED] Propagate stream interest policy changes to consumers in all cases#6995neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/consumerretention
branch
from
5ed4daa to
06467f9
Compare
derekcollison
requested changes
Jun 20, 2025
Member
derekcollison
left a comment
derekcollison
left a comment
There was a problem hiding this comment.
LGTM - but need staticcheck fix on test first.
Member
Author
|
Yep, just fixed it. |
wallyqs
changed the title
neilalexander
added a commit
that referenced
this pull request
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching from limits to interest, we were propagating this update to consumers, but we weren't doing so when switching from interest to limits. This would leave consumers running with
o.retentionset toInterestPolicy, continuing to runcheckStateForInterestStreametc even after the stream itself had moved back to theLimitsPolicy.Signed-off-by: Neil Twigg neil@nats.io