Merged
Conversation
server/jetstream_cluster_1_test.go
Outdated
| mset.mu.Lock() | ||
| mset.node = nil | ||
| mset.mu.Unlock() | ||
| require_True(t, sa.Group != nil) |
Member
There was a problem hiding this comment.
For checking .Group and .Group.node to not be racy, you may need to take the JS lock.
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/node-skew-race
branch
from
b0737ab to
e7021db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a race condition where the stream/consumer health check would delete the group's node if the stream/consumer's node was not yet initialized.
The following would be observed in the logs:
Signed-off-by: Maurice van Veen github@mauricevanveen.com