Skip to content

[FIXED] Remove expected headers when mirroring#6961

Merged
neilalexander merged 1 commit intomainfrom
maurice/mirror-expected-hdr
Jun 10, 2025
Merged

[FIXED] Remove expected headers when mirroring#6961
neilalexander merged 1 commit intomainfrom
maurice/mirror-expected-hdr

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

When publishing a message into a stream with an Nats-Expected-Stream (or other) header, it prevents this message from being stored by a mirror. Previously this was also prevented when sourcing, but that was fixed since 2.10.14 in #5256.

Resolves #5865

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner June 10, 2025 15:54
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 9017f7a into main Jun 10, 2025
90 of 92 checks passed
@neilalexander neilalexander deleted the maurice/mirror-expected-hdr branch June 10, 2025 16:41
@bqiang-stackadapt
Copy link
Copy Markdown

Thank you @neilalexander and @MauriceVanVeen for the fast fix! Wondering why are we planning for the new release? Thank you 🙏

@neilalexander
Copy link
Copy Markdown
Member

Likely in the next week or two, should have release candidates ready for testing either tomorrow or Monday.

neilalexander added a commit that referenced this pull request Jun 17, 2025
Includes the following:

- #6922
- #6931
- #6933
- #6934
- #6939
- #6938
- #6940
- #6941
- #6942
- #6943
- #6945
- #6944
- #6947
- #6948
- #6949
- #6956
- #6960
- #6961
- #6951
- #6965
- #6968
- #6981
- #6983
- #6984

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mirrored stream stops when an invalid source Nats-Expected-Last-Subject-Sequence appears [v2.10.20]

3 participants