[FIXED] Consumer peers drift after server peer-remove#6727
Merged
derekcollison merged 1 commit intomainfrom Mar 26, 2025
Merged
[FIXED] Consumer peers drift after server peer-remove#6727derekcollison merged 1 commit intomainfrom
derekcollison merged 1 commit intomainfrom
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
| // Check if we already have this consumer running. | ||
| o := mset.lookupConsumer(consumer) | ||
|
|
||
| if !alreadyRunning { |
Member
There was a problem hiding this comment.
Is it safe to remove this logic here?
Member
Author
There was a problem hiding this comment.
Yes, createRaftGroup knows if the Raft node already exists and only checks peer differences.
Merged
neilalexander
added a commit
that referenced
this pull request
Apr 17, 2025
Includes the following (already cherry-picked) PRs: - #6587 - #6607 - #6612 - #6609 - #6620 - #6668 - #6674 - #6647 - #6684 - #6691 - #6697 - #6705 - #6706 - #6704 - #6714 - #6720 - #6727 - #6730 - #6726 - #6732 - #6759 - #6753 - #6685 - #6769 - #6777 - #6785 - #6786 - #6778 - #6790 - #6791 - #6798 - #6794 - #6801 Signed-off-by: Neil Twigg <neil@nats.io> Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6720, but for consumer peer sets.
Makes
processClusterCreateConsumermore aligned withprocessClusterCreateStreamby also doing the call tocreateRaftGroup, which proposes the peer change automatically.Signed-off-by: Maurice van Veen github@mauricevanveen.com