[FIXED] AckAll on replicated Interest stream#6587
Merged
derekcollison merged 1 commit intomainfrom Feb 27, 2025
Merged
Conversation
server/jetstream_cluster.go
Outdated
| if o.cfg.AckPolicy == AckAll { | ||
| // Always use the store state, as o.asflr is skipped ahead already. | ||
| // Capture before updating store. | ||
| state, err := o.store.State() |
Member
There was a problem hiding this comment.
Should we use BorrowState here maybe?
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/interest-ack-all
branch
from
6602c3d to
f707a64
Compare
Merged
neilalexander
added a commit
that referenced
this pull request
Apr 17, 2025
Includes the following (already cherry-picked) PRs: - #6587 - #6607 - #6612 - #6609 - #6620 - #6668 - #6674 - #6647 - #6684 - #6691 - #6697 - #6705 - #6706 - #6704 - #6714 - #6720 - #6727 - #6730 - #6726 - #6732 - #6759 - #6753 - #6685 - #6769 - #6777 - #6785 - #6786 - #6778 - #6790 - #6791 - #6798 - #6794 - #6801 Signed-off-by: Neil Twigg <neil@nats.io> Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a consumer with
AckAllon an Interest-based stream would not properly remove messages below the sequence as part of theAckAll.It would not work on the leader because in
processReplicatedAckthe skipped aheado.asflr(=sseq) is used, so thesagap = sseq - o.asflrwould actually besagap == 0. But usingstate.AckFloor.Streamalso doesn't work and results insagap == 0, becauseo.store.UpdateAcks(dseq, sseq)is called first.Should use the state prior to updating for both cases.
Signed-off-by: Maurice van Veen github@mauricevanveen.com