[FIXED] Only forward shadow subs if we are not a leafnode or a hub leafnode client#5519
Merged
derekcollison merged 1 commit intomainfrom Jun 11, 2024
Merged
[FIXED] Only forward shadow subs if we are not a leafnode or a hub leafnode client#5519derekcollison merged 1 commit intomainfrom
derekcollison merged 1 commit intomainfrom
Conversation
…lient. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
changed the title
kozlovic
added a commit
that referenced
this pull request
Sep 4, 2025
This is related to PR #5519 where the propagation of a shadow subscription was suppressed for a subscription coming from a spoke leafnode connection, but the handling of the unsubscribe of such shadow subscription was not fixed, which could result in removing a legitimate interest. The test `TestLeafNodeDupeDeliveryQueueSubAndPlainSub` that was added in PR #5519 was modified to demonstrate what would have been the issue without the fix in this PR. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
derekcollison
added a commit
that referenced
this pull request
Sep 5, 2025
…ode (#7259) This is related to PR #5519 where the propagation of a shadow subscription was suppressed for a subscription coming from a spoke leafnode connection, but the handling of the unsubscribe of such shadow subscription was not fixed, which could result in removing a legitimate interest. The test `TestLeafNodeDupeDeliveryQueueSubAndPlainSub` that was added in PR #5519 was modified to demonstrate what would have been the issue without the fix in this PR. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
MauriceVanVeen
pushed a commit
that referenced
this pull request
Sep 5, 2025
This is related to PR #5519 where the propagation of a shadow subscription was suppressed for a subscription coming from a spoke leafnode connection, but the handling of the unsubscribe of such shadow subscription was not fixed, which could result in removing a legitimate interest. The test `TestLeafNodeDupeDeliveryQueueSubAndPlainSub` that was added in PR #5519 was modified to demonstrate what would have been the issue without the fix in this PR. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #5473
Signed-off-by: Derek Collison derek@nats.io