NRG: Reset election timer when leaving observer mode#5516
Merged
derekcollison merged 1 commit intomainfrom Jun 11, 2024
Merged
Conversation
neilalexander
force-pushed
the
neil/jscmrecovery
branch
2 times, most recently
from
173523e to
2dcd72e
Compare
Previously if `runAsFollower` or `PauseApply` had ran while in observer state, i.e. due to `jetstream_cluster_migrate` being set when leafnode connections dropped, then the election timer would have been reset to a very high value. Then leaving observer state wouldn't have noticed the lack of a leader for some time. This fix allows a leadership election to take place very quickly after leaving observer mode. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/jscmrecovery
branch
from
2dcd72e to
34a9203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if
runAsFollowerorPauseApplyhad ran while in observer state, i.e. due tojetstream_cluster_migratebeing set when leafnode connections dropped, then the election timer would have been reset to a very high value. Then leaving observer state wouldn't have noticed the lack of a leader for some time. This fix allows a leadership election to take place very quickly after leaving observer mode.Signed-off-by: Neil Twigg neil@nats.io