Skip to content

[IMPROVED] Several improvements to raft layer with limited or no state.#5427

Merged
derekcollison merged 1 commit intomainfrom
nrg-no-state
May 16, 2024
Merged

[IMPROVED] Several improvements to raft layer with limited or no state.#5427
derekcollison merged 1 commit intomainfrom
nrg-no-state

Conversation

@derekcollison
Copy link
Copy Markdown
Member

@derekcollison derekcollison commented May 16, 2024

  1. Pull term from tav.idx even with no voted peer on recovery.
  2. If we have no pterm or pindex after recovery inherit from empty WAL and tav.idx.
  3. Clear wtv if we fail to write the tav.idx file.

Also fixes flapper test with removing snapshots and block state.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Several improvements to raft layer with limited or no state.
1a8d16e 
1. Pull term from tav.idx even with no voted peer on recovery.
2. If we have no pterm or pindex after recovery inherit from empty WAL and tav.idx.
3. Clear wtv if we fail to write the tav.idx file.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner May 16, 2024 06:03
wallyqs
wallyqs approved these changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jarema
Jarema approved these changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit bac59ad into main May 16, 2024
@derekcollison derekcollison deleted the nrg-no-state branch May 16, 2024 13:09
@neilalexander neilalexander mentioned this pull request May 16, 2024
Merged
@wallyqs wallyqs mentioned this pull request May 16, 2024
Closed
neilalexander added a commit that referenced this pull request May 16, 2024
@neilalexander
Cherry-picks for 2.10.15-RC.11 (#5429)
d99f8d0 
Includes the following:

* #5405
* #5406
* #5413
* #5419
* #5420
* #5426
* #5427
* #5428

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallyqs wallyqs wallyqs approved these changes

@Jarema Jarema Jarema approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derekcollison @wallyqs @Jarema