Fix acked messages being sometimes redelivered during rollouts #5419
Merged
derekcollison merged 5 commits intomainfrom May 15, 2024
Merged
Fix acked messages being sometimes redelivered during rollouts #5419derekcollison merged 5 commits intomainfrom
derekcollison merged 5 commits intomainfrom
Conversation
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
…plicated ack and if we are still the leader. Signed-off-by: Derek Collison <derek@nats.io>
…il out pch. This allows subsequent scale back up to recreate that go routine. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
pushed a commit
that referenced
this pull request
May 16, 2024
Under some conditions during a rollout, messages that were already acked or double acked (ack sync), would have been redelivered to a consumer. Also includes fixes for `TestJetStreamClusterScaleConsumer` for consumer rescaling. --------- Signed-off-by: Waldemar Quevedo <wally@nats.io> Signed-off-by: Derek Collison <derek@nats.io> Co-authored-by: Derek Collison <derek@nats.io>
wallyqs
added a commit
that referenced
this pull request
May 16, 2024
Under some conditions during a rollout, messages that were already acked or double acked (ack sync), would have been redelivered to a consumer. Also includes fixes for `TestJetStreamClusterScaleConsumer` for consumer rescaling. --------- Signed-off-by: Waldemar Quevedo <wally@nats.io> Signed-off-by: Derek Collison <derek@nats.io> Co-authored-by: Derek Collison <derek@nats.io>
neilalexander
added a commit
that referenced
this pull request
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under some conditions during a rollout, messages that were already acked or double acked (ack sync), would have been redelivered to a consumer. Also includes fixes for
TestJetStreamClusterScaleConsumerfor consumer rescaling.