Fix JWT claims update if headers are passed in request#3918
Merged
Conversation
Jarema
force-pushed
the
jarema/fix-claims-update-with-headers
branch
3 times, most recently
from
d82e9ed to
606c0cf
Compare
Claims update message requires only payload to be passed, but passing headers should not fail the request. This change ensures we extract payload from raw message before decoding it. Before this change, passing claims update with headers would return cryptic `expected x chunks` error. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
jarema/fix-claims-update-with-headers
branch
from
606c0cf to
8732022
Compare
Member
|
|
neilalexander
added a commit
that referenced
this pull request
Oct 10, 2025
Follow-up of #3918, also stripping headers when performing a JWT delete. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claims update message requires only payload to be passed, but passing headers should not fail the request.
This change ensures we extract the payload from the raw message before decoding it.
Before this change, passing claims update with headers would return cryptic
expected x chunkserror.Signed-off-by: Tomasz Pietrek tomasz@nats.io